Skip to content

AutoStory: start gate before a story run presses anything - #396

Merged
dayfine merged 4 commits into
nav/grid-story-stepsfrom
nav/story-start-gate
Nov 11, 2026
Merged

dayfine merged 4 commits into
nav/grid-story-stepsfrom
nav/story-start-gate

Conversation

@dayfine

@dayfine dayfine commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

On console B (2026-11-11 13:32) a BDSP run started with the game on the HOME menu: its first checkpoint saved anyway, pressed X/R/ZL on HOME as a blind fallback, then "loaded" nothing. This adds a preflight hook to the shared story run's start: prepare_story_start() logs the checkpoint that actually starts, then runs the game's StoryGameHooks::preflight and returns StoryPreflight::FAILURE with nothing pressed when its check() fails (video alive, controller ready, game not on HOME). StoryPreflight holds the readings, check() and StoryPreflight::read(), the console reader both games lend; story_first_save_allowed(), beside StoryStart in Types/Pokemon_StoryStart.h, says only a new game saves at its first checkpoint's start (after a load the save is already there; from the game as it is the place is unconfirmed). FROM_SAVE still always loads and checks the place. Tested with the StoryRun suite (new cases red first) via SerialProgramsTests; BDSP and FRLG wiring follows on #381 and #382.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 3 commits November 11, 2026 13:49
prepare_story_start() now logs the checkpoint that starts, then runs the
game's preflight (video alive, controller ready, game not on HOME); one
that fails returns precondition_failed with nothing pressed. A shared
console reader lends the same preflight to BDSP and FRLG.
story_first_save_allowed(): only a new game saves at its first
checkpoint's start; after a load the save is there, and from the game
as it is the place is unconfirmed (console B, 2026-11-11 13:32).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
StoryStartGate.h mixed the start enum, the preflight reading, its failure
code and two start rules. StoryPreflight is now the one concept in its own
header: the preflight hook's reading, its check() and its FAILURE code.
StoryStart and story_first_save_allowed() go back to Pokemon_StoryRun.h
with the start sequence; story_start_name() is internal to it.
Behavior is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Keeps Pokemon_StoryRun.h at its symbol limit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 11, 2026
dayfine added a commit that referenced this pull request Nov 11, 2026
StoryStart moves to Types/Pokemon_StoryStart.h. The console reader joins
StoryPreflight as StoryPreflight::read(); the picture check is internal.
Behavior unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine merged commit 5d01ba7 into nav/grid-story-steps Nov 11, 2026
14 of 15 checks passed
@dayfine
dayfine deleted the nav/story-start-gate branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant