Repository navigation
Conversation
A Player option (boy by default) picks GIRL on the intro's BOY/GIRL menu (pokefirered oak_speech.c window at tile (18, 9)). The facing reader loads the girl's sprite sheet (green_normal.png) next to the boy's and tries both, so a save of either player runs without the setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
gender_menu_cursor() and gender_menu_step() move out of the intro's header and AutoStoryActions.cpp, which were at their size limits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The facing reader tried the boy's sheet and fell back to the girl's, which crashed a console run when green_normal.png was missing. It now takes the Player option's gender and loads that sheet only; the walker passes it on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #352
FRLG AutoStory could only play the boy: the intro always took BOY and the facing reader knew only Red's sprite sheet. This adds a Player option (Boy by default, so existing saves and settings are unchanged) that picks GIRL on the intro's BOY/GIRL menu, located from pokefirered's oak_speech.c window. The same option tells the facing reader (and the walker that calls it) which sheet to load:
red_normal.pngfor the boy,green_normal.pngfor the girl (pret'sOBJ_EVENT_GFX_GREEN_NORMAL, added to dayfine/Packageslab/autostory-resourcesand to the fork CI fetch in #395). Only the chosen sheet is loaded, so a boy run no longer needs the girl's file (an earlier boy-then-girl fallback crashed a console run where it was missing); a save must match the option. Tested with the PlayerFacingReader suite (both real sheets on a synthetic screen, each read by its own sheet and not by the other's), OverworldWalk, and the AutoStory intro tests (BOY/GIRL menu steps, boy then girl); the girl's intro pick is not yet checked on a console.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss