Repository navigation
BDSP AutoStory: save mode none saves at no row's start - #401
Merged
Merged
Conversation
Only PER_CHECKPOINT adds the start save a retry resets to. On console B a run with save mode none saved at 00.05b's and 00.05c's starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With RUN.SAVE_MODE none, console B still saved at 00.05b's and 00.05c's starts, overwriting 00.05's save: make_story_segment() added the start save a retry resets to for every reload-and-retry row, whatever the save mode. It now takes the run's save mode and adds that save only in PER_CHECKPOINT (AFTER_VERIFICATION must not save part-way either). FRLG has no start save of its own, so the shared end-save gate already covers it. A new BDSP AutoStory Simulation case runs 00.04b to 00.05c with save mode none and expects no save: red before the fix, green after; the rest of the PokemonBDSP::AutoStory suites unchanged ("no hand-written legs but the listed ones" fails before and after).
🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss