Repository navigation
Conversation
…table The walker's tile_time(), the sim's timing and the named tap and tile constants now come from Pokemon::FRLG_MOVE_MECHANICS; values unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #402.
Base:
frlg/stage8-rocktunnel, withnav/move-mechanics(#402) merged in; until #402 lands there the diff also shows its three files.FRLG now takes its walking, running and Bicycle tile times, step tap, step tap release and turn tap from
Pokemon::FRLG_MOVE_MECHANICS. The walker'stile_time()and the sim'sSimTimingread the table directly; the named constants inMovementMechanics(TILE_TIME,RUN_TILE_TIME,BIKE_TILE_TIME,STEP_TAP,STEP_TAP_RELEASE,TURN_TAP) are now defined from it and keep their measurement notes, so their other readers are unchanged. All values are the same. Tested in the headless runner with thePokemonFRLGandPokemon::MoveMechanicssuites: the story route plan golden (#393) passes; the failures are image tests without fixtures, AutoStoryResources (local Packages), and OverworldSpin "lift lets out on the floor picked", which fails the same way on the base branch.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss