Skip to content

PokemonBDSP AutoStory: read movement times and taps from the shared table - #404

Merged
dayfine merged 13 commits into
bdsp/autostory-v4from
bdsp/move-mechanics
Nov 12, 2026
Merged

dayfine merged 13 commits into
bdsp/autostory-v4from
bdsp/move-mechanics

Conversation

@dayfine

@dayfine dayfine commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Depends on #402.

Base: bdsp/autostory-v4, with nav/move-mechanics (#402) merged in; until #402 lands there the diff also shows its three files.

BDSP AutoStory now takes its walking and running tile times, start delay, step tap, step tap release and turn tap from Pokemon::BDSP_MOVE_MECHANICS. route_ms_per_tile(), the walker's tap chunks and the planned route's corner taps read the table directly; ROUTE_MS_PER_TILE_*, ROUTE_RUN_MS_PER_TILE_*, ROUTE_START_DELAY and ROUTE_TURN_TAP are now defined from it, so their other readers are unchanged. All values are the same. Tested in the headless runner with the PokemonBDSP and Pokemon::MoveMechanics suites: the plan golden (#392) passes, and the only failures are image tests without fixtures.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 5 commits November 11, 2026 19:37
Tap lengths, tile times per gait and axis, start delay and how open legs
are pressed (BDSP taps, FRLG timed holds on foot), with an entry for BDSP
and one for FRLG and a check of each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
route_ms_per_tile(), the walker's step taps and the route timing and
turn tap constants now come from Pokemon::BDSP_MOVE_MECHANICS; values
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine and others added 2 commits November 11, 2026 21:39

@dayfine dayfine left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed SHA: 88bb10a

Reviewed against bdsp/autostory-v4. The three Pokemon_MoveMechanics* files in the diff are #402's, merged in (byte-identical to #402's head), and are reviewed there.

Verdict

APPROVED (LGTM to merge, after #402)

Correctness: every replaced number has the same value (160ms/640ms -> step_tap/step_tap_release; 800ms chunk = 160 + 640; ROUTE_* aliases = table rows), and route_ms_per_tile() returns the same thing via TileTime::along() (EAST/WEST -> across, else up/down, as the removed across() helper). No planning code changes, so the plan golden is untouched. Code Health: 0 failures (the RouteTiming.h header-size bypass predates this PR).

Findings (optional, non-blocking)

  1. (Nit) PokemonBDSP_AutoStory_RouteWalk.cpp: Pokemon/Navigation/Pokemon_MoveMechanics.h is included after Pokemon_RouteLog.h; keep that block alphabetical.
  2. (Nit) RouteWalk.cpp already has using namespace Pokemon;, so const Pokemon::MoveMechanics& game = Pokemon::BDSP_MOVE_MECHANICS; can drop both prefixes. Same in WalkUntil::press(), where a local game alias like the one in run() would read better than spelling Pokemon::BDSP_MOVE_MECHANICS twice.
  3. (Follow #402) If #402 moves the step tap onto Gait (finding 1 there), the three reads here become BDSP_MOVE_MECHANICS.walk.tap…; a mechanical follow-up.

Notes

  • Fork Draft CI is red from the base: the test run aborts at registration with Duplicate Test Name: PokemonBDSP::ShortDialogDetector - …IntroRowanNameTab_True.png, the same on bdsp/autostory-v4 itself. So no unit test ran in CI; the golden result rests on the local run in the description.

dayfine and others added 6 commits November 12, 2026 00:12
…e messages name expected and actual (#402 review)

FRLG's Bicycle taps 40 ms at one per 100 ms, its walk 66 ms with a 700 ms
release, so the step tap moves from MoveMechanics onto Gait. Every scalar
gets a default, and the test reports which gait and which value failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Follows #402 moving the step tap onto Gait; same 160/640 ms, so presses
are unchanged. Also sorts the MoveMechanics include and drops prefixes the
file's using-declaration covers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine

dayfine commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

Updated at 8c66bc8 (fix: 8c66bc8 on top of merging #402 7f63e8b and bdsp/autostory-v4).

Local headless run (Pokemon::, PokemonBDSP::AutoStory, PokemonBDSP::StoryData): 464 passed, 0 failed. That includes "plans match the golden". Code health: 0.

@dayfine dayfine left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed SHA: 8c66bc8

Delta since my review at 88bb10a: the merges 44c5435 (base) and 7c4607f (#402 at 7f63e8b), and the fix 8c66bc8. The PR's own BDSP files differ from 88bb10a only by 8c66bc8: the base merge left RouteInput.h and RouteTiming.h unchanged. The Pokemon_MoveMechanics* files match origin/nav/grid-story-steps (#402 merged there) byte for byte, so they were reviewed in #402.

Verdict

APPROVED (LGTM to merge, after its parent chain, as before)

  • Correctness: the three reads now use BDSP_MOVE_MECHANICS.walk.tap.{hold,release}, which is {160ms, 640ms} in the table. That is the same as the old step_tap/step_tap_release, so the presses and the 800 ms TAPS chunk are unchanged. No step_tap reference is left in the tree. WalkUntil::press() braces its case for the local tap and still returns inside it.
  • Earlier nits: both resolved. The include block is sorted, and RouteWalk.cpp drops the Pokemon:: prefixes. Finding 3 (follow #402) is done.
  • Checks: Fork Draft CI on 8c66bc8 is green. The duplicate-registration abort is gone and the suite runs, including Pokemon::MoveMechanics - BDSP/FRLG and PokemonBDSP::AutoStory - Simulation: plans match the golden. Code Health passes. The red "Runtime map reader" (native-schema) job fails on the base too and is not from this PR.

Findings (optional)

  1. (Nit) In Walk.cpp, using namespace Pokemon; isn't in scope (unlike RouteWalk.cpp), so the Pokemon:: prefixes there are correct. The same const Pokemon::StepTap& tap = Pokemon::BDSP_MOVE_MECHANICS.walk.tap; is now spelled in both run() and press(). A private member or a file-local constant would say it once. Not blocking.

@dayfine
dayfine merged commit bc33434 into bdsp/autostory-v4 Nov 12, 2026
14 of 17 checks passed
@dayfine
dayfine deleted the bdsp/move-mechanics branch November 13, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant