Repository navigation
Conversation
…maps The planner's press() and the sim each had their own map lookup, warp arrival and edge crossing. Both now read Pokemon::ConnectedMaps; what a step onto the arrival tile does stays here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Conflict in SourceFiles.cmake: kept both file lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #408.
Base:
frlg/stage8-rocktunnel, withnav/connected-maps(#408) merged in; until #408 lands there the diff also shows its files.The planner (
OverworldRoute.cpp) and the sim (OverworldSim.cpp) each looked up maps, warp arrivals and edge crossings with their own copy of the same code. Both now go throughPokemon::ConnectedMaps; the step rules on the arrival tile (elevation, surfing, walking out of a door, lifts) stay here. One small difference: on a side with several connections, the planner used to give up if the first one led to a map that isn't loaded, and both took the first loaded one even when the tile was outside it; now they take the first loaded map that has the tile, as the sim already mostly did. Tested in the headless runner with thePokemonFRLGandPokemon::ConnectedMapssuites: the story route plan golden (#393) passes unchanged; the other failures are image tests without fixtures, files missing from the local Resources, and OverworldSpin "lift lets out on the floor picked", which fails the same way on the base branch.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss