Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
b391160
PokemonFRLG: S14a, Cinnabar Gym quiz and Blaine (14.01, 14.02)
dayfine Nov 12, 2026
1a0e935
fixup: unused constant
dayfine Nov 12, 2026
28ee2d3
PokemonFRLG: Cinnabar Island's save card place; S14a route golden
dayfine Nov 12, 2026
6cd6da6
PokemonFRLG: Cinnabar Gym test message with std::format
dayfine Nov 12, 2026
fa7f838
PokemonFRLG: 14.02 checks the lead is at least pokeguy's Lv40 before …
dayfine Nov 12, 2026
2db13e1
Merge origin/frlg/stage8-rocktunnel into frlg/stage14a-blaine
dayfine Nov 12, 2026
0592eef
Merge origin/frlg/stage8-rocktunnel into frlg/stage14a-blaine
dayfine Nov 12, 2026
c08278b
Merge origin/frlg/stage15-saffron into frlg/stage14a-blaine
dayfine Nov 12, 2026
cd4c72d
FRLG 14.01/14.02: golden carries [tapped]; 14.01's quiz approaches li…
dayfine Nov 12, 2026
0a8f104
FRLG 14.01: register Cinnabar Gym tests in PokemonFRLG_AutoStoryRows1…
dayfine Nov 12, 2026
52d2e22
Merge origin/frlg/stage15-saffron into frlg/stage14a-blaine
dayfine Nov 12, 2026
40f5de6
Merge origin/frlg/stage15-saffron into frlg/stage14a-blaine
dayfine Nov 12, 2026
7abc95f
PokemonFRLG: keep starts_after_unauthored_rows() for 14.01 and 14.03;…
dayfine Nov 12, 2026
4b8cdcf
Merge frlg/stage16-silph into frlg/stage14a-blaine; goldens follow st…
dayfine Nov 12, 2026
b4eff49
Merge frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 12, 2026
ce442b4
Merge remote-tracking branch 'origin/frlg/stage13-mansion' into tmp-7…
dayfine Nov 13, 2026
3af0a3d
Merge frlg/stage13-mansion into frlg/stage14a-blaine (12.01 floor)
dayfine Nov 13, 2026
b84099b
Merge frlg/stage13-mansion into frlg/stage14a-blaine (Mart item names)
dayfine Nov 13, 2026
4e25d5f
Merge frlg/stage13-mansion into frlg/stage14a-blaine (12.01 fills 5 S…
dayfine Nov 13, 2026
fde2285
Merge branch 'm-stage13-mansion' into m-stage14a-blaine
dayfine Nov 13, 2026
bfa2747
FRLG 14.02: Blaine is fought by PokeGuy's solo-recovery policy
dayfine Nov 13, 2026
b27fce5
Merge branch 'm-stage13-mansion' into m-stage14a-blaine
dayfine Nov 13, 2026
a0fb475
Merge frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 13, 2026
970c653
Merge branch 'frlg/stage13-mansion' into frlg/stage14a-blaine
dayfine Nov 13, 2026
3960357
Merge remote-tracking branch 'origin/frlg/stage13-mansion' into frlg/…
dayfine Nov 13, 2026
b114b20
Merge remote-tracking branch 'origin/frlg/stage13-mansion' into HEAD
dayfine Nov 13, 2026
821c9d1
Merge frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 13, 2026
c847195
Merge frlg/stage13-mansion (12.02 split) into stage14a-blaine
dayfine Nov 13, 2026
76c7e53
FRLG 14.02: Blaine alone; the exit, Bill and the heal are 14.02b
dayfine Nov 13, 2026
2a766b0
Merge frlg/stage13-mansion (14.04 split) into frlg/stage14a-blaine
dayfine Nov 13, 2026
ba0c8fe
FRLG AutoStory: the chain test expects 66 checkpoints (the split's me…
dayfine Nov 13, 2026
aaec7fc
Merge remote-tracking branch 'origin/frlg/stage13-mansion' into HEAD
dayfine Nov 13, 2026
da2024f
Merge frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 13, 2026
23dc502
Merge origin/frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 13, 2026
c124618
Merge frlg/stage13-mansion into frlg/stage14a-blaine: upstream #1881 …
dayfine Nov 13, 2026
5422abc
Merge frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 14, 2026
93ec6c6
Merge frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 14, 2026
6ff0981
Merge frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 14, 2026
fde70ec
Merge frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 14, 2026
009e705
Merge origin/frlg/stage13-mansion into frlg/stage14a-blaine
dayfine Nov 14, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
: SmallDictionaryMatcher(dictionary())
{}

static JsonObject dictionary(){

Check warning on line 64 in SerialPrograms/Source/VideoGames/PokemonFRLG/Inference/Menus/PokemonFRLG_SaveCardReader.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

PokemonAutomation::NintendoSwitch::PokemonFRLG::PlaceNameMatcher::dictionary(): function_lines=35 (advisory above 25, limit 50)
JsonObject english;
for (const auto& [slug, name] : {
std::pair<std::string_view, std::string_view>{"pallet-town", "Pallet Town"},
Expand All @@ -86,7 +86,6 @@
{"saffron-city", "Saffron City"},
{"cinnabar-island", "Cinnabar Island"},
{"silph-co", "Silph Co"},
{"cinnabar-island", "Cinnabar Island"},
{"pokemon-mansion", "Pokemon Mansion"},
}){
JsonArray names;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,10 @@ constexpr std::string_view MAP_NAMES[] = {
// Route 7's east gate, where the guard takes the TEA, and Saffron City.
"Route7_EastEntrance",
"SaffronCity",
// Cinnabar Island, and Route 21 north of it to Pallet Town (12.03).
// Cinnabar Island's Center and Blaine's gym, through its quiz doors, and
// Route 21 north of it to Pallet Town (12.03).
"CinnabarIsland",
"CinnabarIsland_Gym",
"Route21_North",
"Route21_South",
// Silph Co.'s floors, 1F to 11F (the lift's map, SilphCo_Elevator, is
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
#include "Programs/AutoStory/PokemonFRLG_AutoStoryRows_Tests.h"
#include "Programs/AutoStory/PokemonFRLG_AutoStoryHealing.h"
#include "Programs/AutoStory/PokemonFRLG_AutoStoryRows12_Tests.h"
#include "Programs/AutoStory/PokemonFRLG_AutoStoryRows14_Tests.h"
#include "Programs/AutoStory/PokemonFRLG_AutoStoryRows15_Tests.h"
#include "Programs/AutoStory/PokemonFRLG_AutoStoryRows13_Tests.h"
#include "Programs/AutoStory/PokemonFRLG_AutoStoryRows16_Tests.h"
Expand Down Expand Up @@ -114,6 +115,7 @@ static void add_tests_AutoStoryRows(UnitTestDatabase& database){
add_tests_AutoStoryHealing(database);
add_tests_AutoStoryCeladonGym(database);
add_tests_AutoStorySaffron(database);
add_tests_AutoStoryCinnabarGym(database);
add_tests_AutoStorySilph(database);
add_tests_AutoStoryMansion(database);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* AutoStory Battle Policy Tests

Check warning on line 1 in SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryBattlePolicy_Tests.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

<file>: file_lines=609 (advisory above 500, limit 1000)
*
* From: https://github.com/PokemonAutomation/
*
Expand Down Expand Up @@ -468,6 +468,19 @@
return check_policy_step("14.04", "erika", {.spa = 1, .accuracy = 2, .outspeed = true, .guard_accuracy = true});
}

UnitTestResult test_plan_blaine(){
const StoryStep& step = battle_step("14.02", "blaine");
const auto foes = arg_of<std::vector<std::string>>(step, "foes");
const auto rows = arg_of<std::vector<std::vector<int64_t>>>(step, "foe_threats");
if (arg_of<std::string>(step, "policy") != "solo-recovery"){
return "14.02 blaine: expected policy solo-recovery.";
}
if (!foes || !rows || !foe_threats_of(*rows) || rows->size() != foes->size()){
return "14.02 blaine: expected one valid foe_threats row per foe.";
}
return true;
}


struct AutoStoryBattlePolicyInput{
std::string name;
Expand Down Expand Up @@ -570,6 +583,10 @@
.input = {.name = "plan: 14.04 erika names the policy, goals and foes", .body = test_plan_erika},
.expectation = {.description = "the policy, goals and 3 foe rows"},
},
{
.input = {.name = "plan: 14.02 blaine names solo-recovery and its foes", .body = test_plan_blaine},
.expectation = {.description = "the policy and 4 foe rows"},
},
{
.input = {.name = "plan: 10.03 rival_tower names the policy, goals and foes", .body = test_plan_tower_rival},
.expectation = {.description = "the policy, goals and 5 foe rows"},
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,320 @@
/* AutoStory Cinnabar Gym Tests
*
* From: https://github.com/PokemonAutomation/
*
* Rows 14.01, 14.02 and 14.02b (StoryData/frlg-14.01.plan.json, 14.02, 14.02b) on the
* overworld sim: from outside the Pokemon Mansion to Cinnabar's nurse,
* into the gym and through its six quiz doors to below Blaine; and from
* Blaine back out through the doors, past Bill, to the nurse. And the
* lead's attacks against Blaine's party.
*
*/

#include <format>
#include <functional>
#include <optional>
#include <string>
#include <string_view>
#include <vector>
#include "Common/Cpp/Exceptions.h"
#include "Common/Cpp/TestRunners/UnitTest.h"
#include "Pokemon/AutoStory/Pokemon_BuiltinStoryActions.h"
#include "Pokemon/AutoStory/Pokemon_StoryStepExecutor.h"
#include "Pokemon/Navigation/Pokemon_MapData.h"
#include "VideoGames/PokemonFRLG/Overworld/PokemonFRLG_OverworldMaps.h"
#include "VideoGames/PokemonFRLG/Overworld/PokemonFRLG_OverworldSim.h"
#include "PokemonFRLG_AutoStoryEvents.h"
#include "PokemonFRLG_AutoStoryParty.h"
#include "PokemonFRLG_AutoStoryRooms.h"
#include "PokemonFRLG_AutoStoryMember.h"
#include "PokemonFRLG_AutoStoryRowSim.h"
#include "PokemonFRLG_AutoStoryRows_Tests.h"
#include "PokemonFRLG_AutoStoryRows14_Tests.h"
#include "PokemonFRLG_AutoStoryTable.h"

namespace PokemonAutomation{
namespace NintendoSwitch{
namespace PokemonFRLG{


namespace{

const std::string GYM = "CinnabarIsland_Gym";

struct AutoStoryCinnabarGymInput{
std::string name;
std::function<UnitTestResult()> body;
};

struct AutoStoryCinnabarGymExpectation{
std::string_view description;
};

struct AutoStoryCinnabarGymCase{
AutoStoryCinnabarGymInput input;
AutoStoryCinnabarGymExpectation expectation;
};

class Test_AutoStoryCinnabarGym : public UnitTest{

Check failure on line 58 in SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryCinnabarGym_Tests.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health

test-case: construct each UnitTest from one case struct with name, input and expectation fields (input and expectation structs, the name outside the input); register a named table of designated cases in a range-for
public:
explicit Test_AutoStoryCinnabarGym(AutoStoryCinnabarGymCase test_case)
: UnitTest(std::format("PokemonFRLG::AutoStory - Simulation: {}", test_case.input.name))
, m_case(std::move(test_case))
{}
virtual UnitTestResult run(Logger&, CancellableScope&) const override{
try{
return m_case.input.body();
}catch (Exception& e){
return std::format("{}: {}", e.name(), e.message());
}
}

private:
AutoStoryCinnabarGymCase m_case;
};

const StoryCheckpoint& checkpoint(std::string_view id){
for (const StoryCheckpoint& row : story_checkpoints()){
if (row.id == id){
return row;
}
}
throw InternalProgramError(nullptr, PA_CURRENT_FUNCTION, std::format("No checkpoint {}.", id));
}

// The rows on the sim, which can't open the quiz doors (the scripts swap
// their metatiles) or walk into a Center with no map. Kept across sims:
// the trainers fought.
struct GymWalk{
StoryPose at;
std::optional<OverworldSim> sim;
std::vector<std::string> fought;

explicit GymWalk(StoryPose start)
: at(std::move(start))
{
place();
}
// A fresh sim on `at`, after a step it can't walk.
void place(){
if (sim){
const std::vector<std::string>& beaten = sim->state().trainers_beaten;
fought.insert(fought.end(), beaten.begin(), beaten.end());
}
sim.emplace(story_maps(), MapPosition{at.map, at.tile}, *at.facing);
}
std::vector<std::string> all_fought() const{
std::vector<std::string> all = fought;
const std::vector<std::string>& beaten = sim->state().trainers_beaten;
all.insert(all.end(), beaten.begin(), beaten.end());
return all;
}
};

// A step of a row on the sim: row_step_on_sim(), but a step through a
// quiz door, the way into the Center and Blaine's battle, which a talk
// starts, leave the player where the table says.
std::string gym_step_on_sim(const StoryStep& step, const std::string& id, GymWalk& walk){
const bool door = step.kind == StoryStepKind::STEP && (step.name.starts_with("into_door_") || step.name.starts_with("through_door_"));
const bool center = step.action == CENTER_ENTER_VARIANT;
if (door || center || (step.kind == StoryStepKind::BATTLE && step.name == "blaine")){
walk.at = *story_pose(Pokemon::pose_of(*step.pose_after));
if (door || center){
walk.place();
}
return "";
}
return row_step_on_sim(*walk.sim, walk.at, step, id);
}

// Row `id`'s steps on the sim from `walk.at`: the failure, or empty.
std::string row_on_sim(std::string_view id, GymWalk& walk){
const StoryCheckpoint& row = checkpoint(id);
for (const StoryStep& step : row.steps){
if (const std::string failure = gym_step_on_sim(step, row.id, walk); !failure.empty()){
return std::format("{}: ended on {}; {}", id, to_string(walk.sim->state().position), failure);
}
if (!walk.sim->state().violations.empty()){
return std::format("{}/{}: a violation on the way: {}", id, step.name, walk.sim->state().violations.back());
}
}
return "";
}

// Whether `tile` of the gym is a wall on the map.
bool gym_wall(const TilePos& tile){
for (const MapData& map : story_maps()){
if (map.name == GYM){
return map.tiles.at(tile) == TileKind::WALL;
}
}
throw InternalProgramError(nullptr, PA_CURRENT_FUNCTION, std::format("No map {}.", GYM));
}

Direction behind(Direction direction){
switch (direction){
case Direction::NORTH:
return Direction::SOUTH;
case Direction::SOUTH:
return Direction::NORTH;
case Direction::EAST:
return Direction::WEST;
default:
return Direction::EAST;
}
}

// Each quiz door is shut on the map, one barrier tile, with floor on both
// sides: the tiles 14.01 steps over.
UnitTestResult test_quiz_doors_on_map(){
const StoryCheckpoint& row = checkpoint("14.01");
int doors = 0;
for (const StoryStep& step : row.steps){
if (!step.name.starts_with("into_door_")){
continue;
}
const StoryPose door = *story_pose(Pokemon::pose_of(*step.pose_after));
const TilePos before = door.tile.next(behind(*door.facing));
const TilePos after = door.tile.next(*door.facing);
if (!gym_wall(door.tile) || gym_wall(before) || gym_wall(after)){
return std::format("{}: expected a barrier on {} between floor tiles.", step.name, to_string(MapPosition{GYM, door.tile}));
}
doors++;
}
return doors == 6 ? UnitTestResult(true) : UnitTestResult(std::format("Expected 6 quiz doors, found {}.", doors));
}

// 14.01 from outside the Mansion: the nurse, the gym and its six quiz
// doors, nobody fought, to below Blaine, where 14.02 starts; 14.02,
// Blaine's battle, which ends where it starts; then 14.02b from there out
// of the gym to the nurse.
UnitTestResult test_gym_rows(){

Check warning on line 191 in SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryCinnabarGym_Tests.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

PokemonAutomation::NintendoSwitch::PokemonFRLG::test_gym_rows(): function_lines=37 (advisory above 25, limit 50)
GymWalk walk(*story_pose(Pokemon::pose_of(*checkpoint("14.01").start)));
if (const std::string failure = row_on_sim("14.01", walk); !failure.empty()){
return failure;
}
const MapPosition below_blaine{GYM, {5, 5}};
if (!(walk.sim->state().position == below_blaine) || walk.sim->state().facing != Direction::NORTH){
return std::format("14.01: ended on {}, not below Blaine {} facing north.", to_string(walk.sim->state().position), to_string(below_blaine));
}
if (!walk.all_fought().empty()){
return "14.01: fought a gym trainer; the quiz is answered instead.";
}
const StoryPose next = *story_pose(Pokemon::pose_of(*checkpoint("14.02").start));
if (next.map != GYM || !(next.tile == below_blaine.point)){
return "14.02 doesn't start where 14.01 ends.";
}
if (const std::string failure = row_on_sim("14.02", walk); !failure.empty()){
return failure;
}
if (!(walk.sim->state().position == below_blaine)){
return std::format("14.02: ended on {}, not in front of Blaine where 14.02b starts.", to_string(walk.sim->state().position));
}
const StoryPose after_blaine = *story_pose(Pokemon::pose_of(*checkpoint("14.02b").start));
if (after_blaine.map != GYM || !(after_blaine.tile == below_blaine.point)){
return "14.02b doesn't start where 14.02 ends.";
}
if (const std::string failure = row_on_sim("14.02b", walk); !failure.empty()){
return failure;
}
if (!walk.all_fought().empty()){
return "14.02b: fought a gym trainer on the way out.";
}
if (walk.at.map != "CinnabarIsland_PokemonCenter_1F"){
return std::format("14.02b: ended on {}, not at Cinnabar's nurse.", walk.at.map);
}
return true;
}

// The lead as pokeguy brings it to Blaine: Surf (12.01, over Water Gun),
// Water Pulse, Bite, Mega Kick. It picks Surf against all four of
// Blaine's Fire types.
UnitTestResult test_lead_moves_against_blaine(){
PartyMember lead;
lead.species = "blastoise";
lead.moves_read = true;
lead.level = 40;
lead.moves = {{"surf", 15}, {"water-pulse", 20}, {"bite", 25}, {"mega-kick", 5}};
for (std::string_view foe : {"growlithe", "ponyta", "rapidash", "arcanine"}){
if (attack_slot_against(lead, {std::string(foe)}) != 0){
return std::format("Against {}: expected Surf.", foe);
}
}
return true;
}

class QuietLogger : public Logger{
public:
using Logger::log;
virtual void log(const std::string&, Color) override{}
};

// Battle checkpoint `id`'s precondition: a LEVEL step on the lead before
// its battle `battle`, at least `pokeguy`, pokeguy's level there (whose
// sims stand for the fight at that level or above). A lead at that level
// passes it; one a level below stops the checkpoint before the fight.
UnitTestResult check_lead_level_precondition(Logger& logger, std::string_view id, std::string_view battle, unsigned pokeguy){

Check warning on line 256 in SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryCinnabarGym_Tests.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

PokemonAutomation::NintendoSwitch::PokemonFRLG::check_lead_level_precondition( Logger & logger , std :: string_view id , std :: string_view battle , unsigned pokeguy): function_lines=28 (advisory above 25, limit 50)
std::optional<LevelCheck> check;
for (const StoryStep& step : checkpoint(id).steps){
if (step.kind == StoryStepKind::BATTLE && step.name == battle){
break;
}
if (step.action == LEVEL_ACTION){
check = level_check_of(step.args);
}
}
if (!check || check->slot != 0 || check->level != pokeguy){
return std::format("{}: expected a LEVEL step on the lead, at least Lv{}, before {}.", id, pokeguy, battle);
}
for (const unsigned level : {pokeguy, pokeguy - 1}){
const MemberReader lead = [level](size_t slot) -> std::optional<MemberInfo>{
if (slot != 0){
return std::nullopt;
}
return MemberInfo{.species = "blastoise", .level = level};
};
const LevelResult result = run_level_check(logger, lead, *check);
const LevelEnd expected = level >= pokeguy ? LevelEnd::REACHED : LevelEnd::BELOW;
if (result.end != expected || result.level != level){
return std::format("{}: a Lv{} lead {} the Lv{} check.", id, level, level >= pokeguy ? "fails" : "passes", pokeguy);
}
}
return true;
}

const AutoStoryCinnabarGymCase AUTO_STORY_CINNABAR_GYM_CASES[] = {
{
.input = {.name = "Cinnabar Gym's quiz doors are shut on the map", .body = test_quiz_doors_on_map},
.expectation = {.description = "each of 14.01's door steps crosses one barrier tile between floor"},
},
{
.input = {.name = "14.01 through the quiz to below Blaine, 14.02 on the spot and 14.02b back to the nurse", .body = test_gym_rows},
.expectation = {.description = "no gym trainer fought; ends at Cinnabar's nurse"},
},
{
.input = {.name = "the lead's attacks against Blaine", .body = test_lead_moves_against_blaine},
.expectation = {.description = "Surf against each Fire type"},
},
{
.input = {.name = "14.02 stops before Blaine unless the lead is at least pokeguy's Lv40", .body = []{
QuietLogger logger;
return check_lead_level_precondition(logger, "14.02", "blaine", 40);
}},
.expectation = {.description = "a Lv40 lead passes the LEVEL step, a Lv39 one stops there"},
},
};

} // namespace


void add_tests_AutoStoryCinnabarGym(UnitTestDatabase& database){
for (const auto& item : AUTO_STORY_CINNABAR_GYM_CASES){
database.add<Test_AutoStoryCinnabarGym>(item);
}
}



} // namespace PokemonFRLG
} // namespace NintendoSwitch
} // namespace PokemonAutomation
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* AutoStory Events

Check warning on line 1 in SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryEvents.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

<file>: file_lines=997 (advisory above 500, limit 1000)
*
* From: https://github.com/PokemonAutomation/
*
Expand Down Expand Up @@ -349,7 +349,7 @@
return StoryPose{pose.map, tiles[0], facing_of(pose)};
}

std::string save_card_place(const std::string& map){

Check warning on line 352 in SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryEvents.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health (advisory)

PokemonAutomation::NintendoSwitch::PokemonFRLG::save_card_place( const std :: string & map): function_lines=33 (advisory above 25, limit 50)
// A map of the place, or a building in it ("Route4_PokemonCenter_1F"
// is on Route 4, "Route24" isn't on Route 2).
static const std::pair<std::string, std::string_view> PLACES[] = {
Expand All @@ -373,7 +373,6 @@
{"SaffronCity", "saffron-city"},
{"CinnabarIsland", "cinnabar-island"},
{"SilphCo", "silph-co"},
{"CinnabarIsland", "cinnabar-island"},
{"PokemonMansion", "pokemon-mansion"},
};
for (const auto& [prefix, place] : PLACES){
Expand Down
Loading
Loading