Repository navigation
Conversation
Shared plumbing for seam 3's sim goldens: a golden's path beside its test, its text, the first differing line, and a check that rewrites the file when PA_UPDATE_SIM_GOLDENS is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…oldens # Conflicts: # SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp # SerialPrograms/cmake/SourceFiles.cmake
…t sweeps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 12, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
… mine plan replay step) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 13, 2026
…engine) Reapplies a7ee7c1 (reverted in dcbd5a4). The shared SimGolden/SimFaults files are autostory/engine's. FaultSweep_Tests keeps BDSP's own FaultClass: its START_OFFSET has no shared counterpart yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #419. Base
bdsp/center-run-settle(#375), withnav/sim-goldens(#419) merged in; the diff also shows #419 and thenav/grid-story-stepscommits under it (ScreenObservation, ZonePose, Grid.h); this PR's own files are the BDSPSimGolden_Testspair, the two goldens,PokemonBDSP_Tests.cppandSourceFiles.cmake.Seam 3 will move BDSP's grid sim onto the shared sim core, and nothing pinned down what the sim does today. This adds two goldens beside the BDSP sim tests:
sim_golden_rows.txtruns each row 00.00 to 01.11 clean on the story simulation and records whether it completed, where the player ended, the stubbed steps, the fades, banners, doors and tap steps looked for, and every walk and leg line;sim_golden_faults.txtrecords each fault sweep's outcome and summary lines.PA_UPDATE_SIM_GOLDENS=1rewrites them.Tested with the headless runner: both goldens written, then checked clean on a second run (
PokemonBDSP::AutoStory - Sim golden, 2 passed). Note:bdsp/center-run-settleregisters the BDSP DialogDetector and MenuDetector tests twice (inadd_testsand the runner), which aborts the runner with "Duplicate Test Name"; I dropped the duplicates in a local scratch tree only, not in this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss