Skip to content

BDSP AutoStory: golden files for the story simulation - #421

Draft
dayfine wants to merge 13 commits into
bdsp/center-run-settlefrom
bdsp/sim-goldens
Draft

dayfine wants to merge 13 commits into
bdsp/center-run-settlefrom
bdsp/sim-goldens

Conversation

@dayfine

@dayfine dayfine commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Depends on #419. Base bdsp/center-run-settle (#375), with nav/sim-goldens (#419) merged in; the diff also shows #419 and the nav/grid-story-steps commits under it (ScreenObservation, ZonePose, Grid.h); this PR's own files are the BDSP SimGolden_Tests pair, the two goldens, PokemonBDSP_Tests.cpp and SourceFiles.cmake.

Seam 3 will move BDSP's grid sim onto the shared sim core, and nothing pinned down what the sim does today. This adds two goldens beside the BDSP sim tests: sim_golden_rows.txt runs each row 00.00 to 01.11 clean on the story simulation and records whether it completed, where the player ended, the stubbed steps, the fades, banners, doors and tap steps looked for, and every walk and leg line; sim_golden_faults.txt records each fault sweep's outcome and summary lines. PA_UPDATE_SIM_GOLDENS=1 rewrites them.

Tested with the headless runner: both goldens written, then checked clean on a second run (PokemonBDSP::AutoStory - Sim golden, 2 passed). Note: bdsp/center-run-settle registers the BDSP DialogDetector and MenuDetector tests twice (in add_tests and the runner), which aborts the runner with "Duplicate Test Name"; I dropped the duplicates in a local scratch tree only, not in this PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 5 commits November 12, 2026 00:36
Shared plumbing for seam 3's sim goldens: a golden's path beside its
test, its text, the first differing line, and a check that rewrites the
file when PA_UPDATE_SIM_GOLDENS is set.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…oldens

# Conflicts:
#	SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp
#	SerialPrograms/cmake/SourceFiles.cmake
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…engine)

Reapplies a7ee7c1 (reverted in dcbd5a4). The shared SimGolden/SimFaults
files are autostory/engine's. FaultSweep_Tests keeps BDSP's own FaultClass:
its START_OFFSET has no shared counterpart yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant