Repository navigation
Conversation
The nth fade, hold, banner, dark door run and through tap step now come from Pokemon::FaultOccurrences instead of hand-kept size_t counters; the knobs keep counting from 0, as the tests set them, and arm_misses() turns them into the counters' chance numbers, from 1. The run's counts are read with looked_for(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…mine plan replay step) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 13, 2026
…engine) Reapplies a7ee7c1 (reverted in dcbd5a4). The shared SimGolden/SimFaults files are autostory/engine's. FaultSweep_Tests keeps BDSP's own FaultClass: its START_OFFSET has no shared counterpart yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 13, 2026
…eads the shared chance counters route_plans.golden.txt regenerated with PA_UPDATE_ROUTE_PLANS=1 on the lab's 01.02 and 00.05c plans; it now equals lab/dev-bdsp's golden. #429 replaced SimMisses' fade and banner counts with FaultOccurrences, so the Monte Carlo test reads their chances(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #423. Base
bdsp/sim-faults; the diff shows only this change.BDSP's
SimMissespicked the nth fade, hold, banner, dark door run and through tap step with its ownsize_tcounters (m_misses.fade == m_misses.fades++). It now counts them on the sharedPokemon::FaultOccurrencesfrom #422, one per miss, as FRLG's sim does in #424. The misses are detection misses with no sharedFaultClass(fade or banner unseen, a false dark read, a tap step begun past the warp), so they stay BDSP's own knobs: tests still set them counting from 0,arm_misses()turns them into the counters' chance numbers (from 1), andlooked_for()reads how many chances a run saw.Tested with the headless runner, before and after:
PokemonBDSP::AutoStory(story sims, detector-miss Monte Carlo, fault sweeps, sim goldens) gives the same verdicts, 297 passed and the same 5 failing on the base (resources, plan goldens, hand-written legs, overshoot sweep); the golden files are unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss