Skip to content

BDSP MenuDetector: narrow the white columns clear of the cursor glow - #430

Merged
dayfine merged 1 commit into
bdsp/detectors-v4from
bdsp/menu-detector-cursor-glow
Nov 13, 2026
Merged

dayfine merged 1 commit into
bdsp/detectors-v4from
bdsp/menu-detector-cursor-glow

Conversation

@dayfine

@dayfine dayfine commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Depends on #152 (base bdsp/detectors-v4); the diff shows only this change.

AutoStory 00.05c failed three loads in a row with "Menu not detected after 10 seconds." while the X menu was on screen. The cursor was on the map (first icon of the second row), and the selected icon's glow reaches about 0.008 left of the icon, into the first white column (0.166 + 0.015), so that column's stddev rose to about 12, over the white test's 10.

  • The columns are now 0.010 wide and end just short of the glow. This also gives the new-game BAG/OPTIONS image more margin (its first column read 9.3 of 10).
  • New image test FrenchCursorOnMap_True.png (French menu, cursor on the map, NEW tag on the Trainer Card), with both column modes. The case table moved to namespace scope to keep add_tests_MenuDetector under the length limit.

Testing: SerialProgramsTests --filter PokemonBDSP::MenuDetector --augment-color-distortions: before the fix the two new cases fail (20/22), after it 22/22, all existing positives and negatives unchanged. The new image is not in CommandLineTests yet (local copy at ~/BDSPLab/clt-pending/PokemonBDSP/MenuDetector/), so CI reports a FileException for these two cases.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

The selected menu icon glows about 0.008 past its left edge. With the
cursor on the first icon of a row (TOWN MAP on the second row), the
first 0.015-wide column took the glow's edge and its stddev rose to
about 12, over the white test's 10, so overworld_to_menu() timed out
with the menu on screen. Columns of 0.010 end just short of the glow.

New image test: a French menu with the cursor on the map and a NEW tag
on the Trainer Card (both column modes).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine
dayfine merged commit 5358225 into bdsp/detectors-v4 Nov 13, 2026
13 of 17 checks passed
@dayfine
dayfine deleted the bdsp/menu-detector-cursor-glow branch November 13, 2026 03:30
@dayfine

dayfine commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

Folded into #152 (merge 5358225).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant