Repository navigation
BDSP MenuDetector: narrow the white columns clear of the cursor glow - #430
Merged
Merged
Conversation
The selected menu icon glows about 0.008 past its left edge. With the cursor on the first icon of a row (TOWN MAP on the second row), the first 0.015-wide column took the glow's edge and its stddev rose to about 12, over the white test's 10, so overworld_to_menu() timed out with the menu on screen. Columns of 0.010 end just short of the glow. New image test: a French menu with the cursor on the map and a NEW tag on the Trainer Card (both column modes). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #152 (base
bdsp/detectors-v4); the diff shows only this change.AutoStory 00.05c failed three loads in a row with "Menu not detected after 10 seconds." while the X menu was on screen. The cursor was on the map (first icon of the second row), and the selected icon's glow reaches about 0.008 left of the icon, into the first white column (0.166 + 0.015), so that column's stddev rose to about 12, over the white test's 10.
FrenchCursorOnMap_True.png(French menu, cursor on the map, NEW tag on the Trainer Card), with both column modes. The case table moved to namespace scope to keepadd_tests_MenuDetectorunder the length limit.Testing:
SerialProgramsTests --filter PokemonBDSP::MenuDetector --augment-color-distortions: before the fix the two new cases fail (20/22), after it 22/22, all existing positives and negatives unchanged. The new image is not in CommandLineTests yet (local copy at~/BDSPLab/clt-pending/PokemonBDSP/MenuDetector/), so CI reports a FileException for these two cases.🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss