Repository navigation
AutoStory: breakpoints, pause before each step and leg - #448
Merged
Merged
Conversation
…tion, engine) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…kpoints (set_pause_points) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 13, 2026
dayfine
added a commit
that referenced
this pull request
Nov 13, 2026
# Conflicts: # SerialPrograms/Source/Pokemon/AutoStory/Engine/Pokemon_StoryEngineRuns_Tests.cpp
Moved from the FRLG stack, where 0ac33f9 added it inside a game PR (FRLG names its route screenshots by the step under way). (cherry picked from commit 0ac33f9, Pokemon_StoryBreakpoints.h only) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
TEXT_BOX -> DIALOG_BOX, BATTLE -> BATTLE_STARTED, CAN_MOVE -> PLAYER_CAN_MOVE, STILL -> SCREEN_STILL; Pokemon:: screen event names are now in PokemonAutomation (CommonTools/ScreenEvents). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
commented
Nov 14, 2026
dayfine
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: mergeable on the fork
Reviewed SHA: fda56d1
Verdict
APPROVED
Correctness pass on git diff origin/autostory/engine...origin/autostory/story-breakpoints, then a style pass. CI green (Fork Draft CI, code health). No existing comments. No blocking findings.
Should-fix
Engine/Pokemon_StoryEngine.cpp:42,:52—RunnerExecutorbuilds its own step pause (m_pause,m_checkpoint, a name search for the index) next to the wrapper this PR adds inPokemon_StoryStepExecutor.cpp:112. The engine already passesRunnerExecutortobuild_story_checkpoint(), soset_pause_points(&pause)in its constructor would give the same pauses with the index the builder already has. As it is, there are two label derivations, and the engine one prints"/N+1"with an empty checkpoint id ifbegin_attempt()was not called first.Engine/Pokemon_StoryActionRegistry.h:63,:82—mutable StoryPausePoints m_pausewith aconstaccessor that returns a non-const reference puts per-run state inside the game's action registry (the comment says so). The engine can own theStoryPausePointsand hand it to the registry'sdispatch(); then themutablegoes away.Options/Pokemon_StoryRunOptions.cpp:123—BREAKPOINTSis a user-visible dropdown, but nothing on this branch readsbreakpoints()intoStoryGame, and only a lab build installs a wait. In a release build it never does anything. Either wire it in the game PRs before they leave the fork, or hide it outside developer mode.
Nits
Types/Pokemon_StoryBreakpoints.h:46—const std::optional<TilePos>&: takestd::optional<TilePos>by value, per our C++ style rule (TotW #163).Types/Pokemon_StoryBreakpoints.h:65,:68—before_leg()andpause()only read the label, so they should takestd::string_viewby value.before_step()stores it, so it should takestd::stringby value and move it.
…merged, review fixes Conflict: the engine-runs test table takes the engine's case shape (name outside the input); the breakpoint rows are written in it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #332 (base
autostory/engine; the diff shows only this change).AutoStory can pause before each step, or before each leg of a walk too, so a person can look at the console and then continue (a debugger's breakpoints).
StoryGame::breakpointsandpause_point(label)hook; the engine calls it before each step with12.03/5 pallet_shore, the shared walk action before each leg with... leg 2/5 east 4 -> (10, 10). Default: off, no hook, no-op.StoryRunOptions::BREAKPOINTS(off / steps / legs), so every game that uses the shared options gets it. The program setsgame.breakpointsandgame.pause_point = make_story_pause_hook(scope).[Break] <label>: pausedand: continued. A normal build installs no wait (set_story_pause_wait()), so a pause never blocks; a lab build installs one that waits and ends with the scope.StoryActionCall::pause.before_leg(...)the same way in follow-ups.Testing:
SerialProgramsTests --filter Pokemon::StoryEngine(70 passed): hook before each step and leg in order with labels, off and no-hook never pause, the installed wait gets label and scope. Code health 0 failures.Update 2026-11-13 (b0f28bc, 21b8a73): merged the current autostory/engine;
StoryPausePoints::step_label()moved here from FRLG's 0ac33f9, where a game PR had added it.