Skip to content

FRLG AutoStory: Fly by species opens the party once - #453

Draft
dayfine wants to merge 15 commits into
frlg/stage19-victory-roadfrom
frlg/party-menu-once
Draft

dayfine wants to merge 15 commits into
frlg/stage19-victory-roadfrom
frlg/party-menu-once

Conversation

@dayfine

@dayfine dayfine commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Base: frlg/stage19-victory-road (#446). The diff shows only this change.

A Fly naming a species opened and closed the start menu for every slot it read, then opened it again to fly. Now the party opens once for the whole Fly, and no summary is read.

  • A Fly finds its user from the party menu itself: A on a member opens its menu, which lists its field moves in blue under SUMMARY. The new PartyMemberMenuReader reads that menu from CANCEL up and OCRs the blue rows against the field move names. The scan walks the cursor down the party, opens each member's menu (B if no FLY) and stops at the first that lists FLY, picking it right there on its row.
  • A menu that isn't read, or a blue row whose name isn't read, stops the Fly (fly_menu_unread) with the party closed and a debug image saved.
  • Who uses each field move (slot + species, e.g. fly=3:pidgey) is kept in AutoStory's "Field move users" option at each save, as the SID is kept. A later Fly opens that slot's menu first and only verifies FLY there; if it's missing, it B's out and scans the rest in the same party menu.
  • A TEACH naming a species still finds its slot through the summary scan and its cache (SpeciesFinder).

Testing: AutoStory - Party roster (fake party counting party opens, member menus opened/closed and summaries: first Fly stops at the Pidgey's menu, FLY's row, recorded user, stale record, unread menu/name, no Fly user, restart) went 7 red to 21 green; PartyMemberMenuReader on two console B captures (the Pidgey's menu with FLY, the party list) went red to green. The rest of the AutoStory suites show only the known local fixture failures (18). Not run on the console. The reader's fixtures need a CommandLineTests PR: PokemonFRLG/PartyMemberMenuReader/PidgeyFly_eng.png, PartyList_eng.png.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 6 commits November 12, 2026 23:38
A Fly naming a species read every slot with its own open/close of the
start menu, then opened the menu again to fly. A PartyRoster scan now
opens the party once, enters slot 1's summary, pages with D-pad down
until the species matches, and backs out to that member's menu to pick
FLY. The species read are cached in StoryEnv (cleared on a save load
and on PC deposit/withdraw), so a later Fly or species TEACH reads no
summary.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
A TEACH of an HM or field move (Fly, Surf, Strength, Cut, Flash, Rock
Smash, Dig...) records the move's user, slot and species, in the story
state next to the saved supplies: a save keeps a copy, a load restores
it, a PC deposit or withdrawal clears it. A Fly naming a species opens
the party, picks the recorded slot and the FLY row, and reads no
summary. If that menu does not give Fly, the party is closed, the record
dropped, and the #453 scan finds the member and records it again; a scan
records what it finds for the next Fly.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Who uses each field move (slot and species, "fly=3:pidgey") is written to
AutoStory's Field move users option after each save and read at the start,
so a Fly after the program restarts goes to the slot without a party scan.
An unreadable entry is dropped and logged; a record of another species or
a slot that doesn't give the move falls back to the scan, as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…dMoveUsers); option text as constants

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
dayfine added a commit that referenced this pull request Nov 13, 2026
Conflicts with #453's party cache: run_field_move_step takes both the player (Fly landing reads the facing) and the PartyCache; the departure snapshot is taken before the party is opened; StoryEnv keeps party/field moves/master ball and the pause points; keep_field_move_users and set_breakpoints both kept. 12.03 plan comes from #450 unchanged (Pallet shore (10, 16), straight out of the Center).
dayfine added a commit that referenced this pull request Nov 13, 2026
…kpoint through 20.05

Adds 16.02-16.06 (#444), 18.01-18.02 (#443), 19.04b-d and 20.01-20.05 (#457/#458), #453 party menu once. Conflict: the unit test runner registers ConnectedMaps and MoveMechanics tests as #458 does.
dayfine added a commit that referenced this pull request Nov 13, 2026
… the party menus for FLY

Conflict: run_field_move_step's comment in FieldMoves.h; kept #453's menu scan
and the Fly landing judgement from #450.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…arty menu, #463 surf legs that land

Conflict: OverworldRecovery.cpp's DONE step; took #463's after_done() and kept
#451's m_known update inside it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine and others added 3 commits November 13, 2026 08:41
…a Fly scan past an unread menu

The Oddish's menu on console B (12.03, SWEET SCENT and CUT) isn't read, and
the Fly scan stops there instead of trying the Pidgey under it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…y scan passes an unread menu

SWEET SCENT and its light blue shadow cover half its row, so the row
wasn't taken for the menu's window and the Oddish's menu (SWEET SCENT,
CUT) wasn't read at 12.03. The shadow now counts as the window's. A
member's menu that isn't read is closed with B and the scan goes on;
it fails as unread only if no other menu lists the move.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant