Skip to content

FRLG AutoStory 12.03 false pass: save only where the checkpoint ends; no unfaded door on water - #463

Draft
dayfine wants to merge 14 commits into
frlg/stage19-victory-roadfrom
frlg/save-postcondition
Draft

dayfine wants to merge 14 commits into
frlg/stage19-victory-roadfrom
frlg/save-postcondition

Conversation

@dayfine

@dayfine dayfine commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

On console B, 12.03 stopped short of Cinnabar while surfing on Route 21. It took the Center's door and the heal as done and saved there: the card read ROUTE 21 and the Fuchsia save was lost. The save now reads the card's place before the first YES. If the place isn't the checkpoint's end map (the next row's start), or the card can't be read, it answers NO, goes back to the overworld and fails. The card reader also knows Routes 21 to 23. A door north whose fade went unseen now counts as taken only if the black below the building is on screen; the waves passed for the Center before. New cases in the AutoStory and OverworldWarpFade unit suites failed before the fixes and pass now. The console's card dump (20261113-041629128559-save-card.png) still needs to go into CommandLineTests as a SaveCardReader image.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

dayfine and others added 2 commits November 13, 2026 04:53
12.03 saved on Route 21 (card ROUTE 21) instead of Cinnabar's Center
(console B, 2026-11-13 04:16). save_game() now reads the card's place
before the first YES; a place other than the checkpoint's end map (the
next row's start), or an unreadable card, answers NO and fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…e building

On Route 21 the waves after a step into the Center were taken as the
Center (12.03, console B, 2026-11-13).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@dayfine dayfine changed the title FRLG AutoStory: save only where the checkpoint ends, by the save card FRLG AutoStory 12.03 false pass: save only where the checkpoint ends; no unfaded door on water Nov 13, 2026
dayfine and others added 8 commits November 13, 2026 05:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…s to SaveChecks.cpp; split FRLG add_tests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…o open water leg goes on from a guess

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… SELECT and RNG returns to their headers' .cpp

heal_in_center() moves from PokemonFRLG_AutoStoryEvents.h (9 symbols) to
PokemonFRLG_AutoStoryCenterHeal.h. select_onto_bike(), screen_shows_riding()
and get_on_bike() move unchanged from PokemonFRLG_OverworldWalk.cpp to
PokemonFRLG_OverworldBike.cpp; close_trainer_card() and leave_gift_summary()
from PokemonFRLG_AutoStoryActions.cpp to PokemonFRLG_AutoStoryRngReturns.cpp,
next to the headers that declare them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
Conflicts: HealingSteps includes keep both sides; PlanGolden12.h is the lab's resolution of #450 + #463 (lab/dev-frlg-stage8 ea2a0c9), which merged the same two tips. 12.03 plan now matches the lab's console version (a3a3e01).
dayfine and others added 4 commits November 13, 2026 07:06
Console B, 2026-11-13 04:15, 06:55 and 07:02: 12.03's legs on Route 21's
water ended in the open, and a message (WhiteDialogWatcher) stopped
"south 15 (open)" 8 tiles in, where the player couldn't be found again.

- RouteStep::lands_after: a leg on the water that lands on a sand bar,
  an island or the shore keeps going on foot and is held to the bank
  (to_wall); walk_overworld_route() checks with PlayerFacingReader that
  the player is on foot after it, and fails if they still surf.
- Dismounting no longer splits a leg; RouteCost::OPEN_WATER_STOP makes
  stops on open water cost more than landing.
- 12.03's plan lands on Route 21's two sand bars and the beach.
- Sim: landing hop and walk pace per step, a message after any surfed
  step (SimScript::messages_at_surf_steps), holds on the water recorded.
- Tests: AutoStory - Surf (12.03 end to end, a message after every
  surfed step, each water hold stopped short), five PlayerFacingReader
  fixtures from Route 21, golden plans for 06.01, 12.03, 19.02, 19.03.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…aps, Surf tests header

- RouteCalls::landed_on(tile) replaces on_foot(); RouteRun::after_done()
  holds a finished leg's bookkeeping and the landing check.
- OverworldSim::take_steps() and the new message_on_water() go to
  PokemonFRLG_OverworldSimTaps.cpp; route_action() out of to_route_step().
- add_tests_AutoStorySurf() gets its own header; Surf cases use the
  input/expectation case structs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…egs that land

12.03 takes #463's Route 21 legs (sand bars, then the beach) from Pallet's
shore at (8, 16), and keeps #450's walk straight out of Fuchsia's Center.
RouteCalls and the facing reader's tests keep both sides; the wanderer check
keeps 13.03's to_elixir and incidental fights next to #463's Swimmer Roland.
OverworldSim.h is LF on this line since the gates merge; #463's change is
applied to it without changing its line endings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…lans it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…ions

The #463 merge put Swimmer Roland's exemption beside Lewis's and the incidental
fights in check_lines(), past its 50-line limit; they move to a helper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit that referenced this pull request Nov 13, 2026
…arty menu, #463 surf legs that land

Conflict: OverworldRecovery.cpp's DONE step; took #463's after_done() and kept
#451's m_known update inside it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant