Repository navigation
Conversation
TalkOverRule::door ends the settle after a door or warp on a still box around the player (the new PLAYER_STILL event) for 1 s, or on the overworld being back for 2.5 s, so people walking about a Center neither hold the settle up nor end it early. As bdsp/rebuild-base carries it, without its stray blank lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 14, 2026
… shared door settle Kept rebuild-base's TalkOver (from autostory/engine) and dropped its stray blank lines, as #469 has them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on nav/grid-story-steps at ea17f73, the commit #464 uses; the diff shows only this change.
After a door, TalkOver waited for the whole screen to be still, so Center visitors walking about held the settle up or ended it early. TalkOverRule::door now ends it on a still box around the player (the new PLAYER_STILL screen event) for 1 s, or on the overworld being back for 2.5 s. This came from bdsp/rebuild-base, which has no PR; bdsp/rebuild-base merges this branch. Compiled locally; the BDSP sim tests in the rebuild chain cover it, and Fork Draft CI runs the suites.
🤖 Generated with Claude Code
https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss