Repository navigation
Conversation
…y is not on this base)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #485
Base
lab/slice4-prechecks; the diff is one empty commit. This PR holds a design note only: FRLG AutoStory is not on this base. It lives on the FRLG stack (program added in #352frlg/stage1-program, current code at the stack tip #458frlg/stage20-league), which does not containupstream/frlg-free-party-slots. Per the brief I did not merge the FRLG stack in.Where it must stack. A branch off the FRLG stack tip (
frlg/stage20-leagueonce its agent is done, orfrlg/stage19-victory-roadnow) withlab/slice4-prechecksmerged in. A trialgit merge-treeof #485 into both is conflict-free. That merge also bringsupstream/frlg-free-party-slots(PokemonAutomation#1881) into the FRLG stack, which needs the user's OK.What I'd change there. In
PokemonFRLG_AutoStory.cpp,program()today callscheck_setup()andrequire_preflight()(Pokemon::StoryPreflight: video alive, controller ready, not HOME). I'd replace both with aPrecheckListbuilt by a side-effect-freeautostory_prechecks(...)and run byrun_prechecks()beforeverify, the SID Helper stop and any reset:game_open(ALWAYS_RUNS, first): StoryPreflight's video/controller/not-HOME read, as aPrecheck.black_border(ALWAYS_RUNS): the existing FRLG black border check from Prechecks: a program's start checks as a named list, FRLG RNG first #485.known_screen(ALWAYS_RUNS): title screen for 01.01 with NEW_GAME_FROM_TITLE, otherwise the overworld or the start menu; refuses a post-run summary or a battle.start_checkpoint(ALWAYS_RUNS, no console read): the start is chosen by checkpoint id, not by index, and refuses a dev-only row while Developer Mode is off; the start/end order and 01.01 rules fromcheck_setup()move here.language(SKIPPABLE): LANGUAGE matches the cartridge, read from the title screen or start menu text where detectable; PASSED with "not detectable here" otherwise.The StoryRangeOptions dropdown would need an id accessor (
start_id()) so a hidden row cannot shift the index. Native tests (in the style ofPokemonFRLG_Prechecks_Tests) would check the list's names and order and that HOME frames, a mismatched language and a hidden checkpoint id each fail with nothing pressed. Programs without a list report unsupported.Not tested: nothing to build.