Skip to content

PLZA AutoStory: shared failure classes and a fault sweep of 03.07d and 03.08 - #492

Draft
dayfine wants to merge 12 commits into
plza/story-enginefrom
plza/fault-sweep
Draft

dayfine wants to merge 12 commits into
plza/story-enginefrom
plza/fault-sweep

Conversation

@dayfine

@dayfine dayfine commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Base: plza/story-engine (#335), merged in at 361376b (03.08 now ends out of Wild Zone 1: walk_back_to_zone_road, walk_to_zone_gate_entrance, then check_out_of_wild_zone); merges in nav/shared (9a093ab, with #479 fault classes). The diff also shows nav/shared's commits until #335 takes them.

PLZA AutoStory now reports the shared story failure classes and runs the shared fault sweep over 03.07d and 03.08.

  • PokemonLZA_AutoStoryFailures: PLZA's own failure names take a class through plza_failed(), so the engine's lines end (class=<id>). gate_not_seen/heading_missed → pose_lost; no_prompt, heading_unread, platform_not_seen, scene_* → screen_unread; walk_no_end → late_fade; walk_not_free → interrupt_failed; not_at_start/older_save → wrong_start; no_reload → reload_failed; battle_failed → battle_lost. Console step throws: walk_to_zone_1_start → zone_start_missed, walk_back_to_zone_road → zone_road_missed, check_out_of_wild_zone → zone_exit_missed (all walk_short); catch_in_zone stays operation_failed.
  • PokemonLZA_AutoStoryFaultSweep_Tests: a row sim of the steps that need no console (timed walks, the walk to a zone's gate, A through a prompt) injects lost_tap, late_fade, warp_no_op, slow_fade_in and scene_end_pose over both rows. A gate walk with no heading (03.08's) walks toward the way the clean run faced at its start.
  • Fixes the sweep found: a timed walk plays a leg again when the screen stays still after it; press_a_first waits for the fade and presses A again while the prompt stays.
  • Known failing, with the likely fix: 03.07d and 03.08 warp_no_op (A again after a no-op fade could undo a real warp; read the minimap's zone green after the fade first).

Testing: unit tests run on Fork Draft CI (the earlier local run: all new tests passed, image tests failed only on frames missing locally). Code health: 0 failures.

dayfine and others added 12 commits November 14, 2026 14:35
# Conflicts:
#	SerialPrograms/Source/Pokemon/AutoStory/Engine/Pokemon_StoryLaunch_Tests.cpp
…d and 03.08

PLZA's own failure names (gate_not_seen, no_prompt, scene_*, not_at_start,
...) take a class from the shared list through plza_failed(), so the
engine's failure lines end "(class=<id>)". walk_to_zone_1_start's thrown
failure is zone_start_missed (walk_short).

A row sim of the steps that need no console (timed walks, the walk to a
zone's gate, A through a prompt) runs the shared fault sweep over 03.07d
and 03.08: lost_tap, late_fade, warp_no_op, slow_fade_in, scene_end_pose.
Six cells are known failing, with the likely fix: open-loop timed walks,
and press_a_first ending on the prompt's party bar before the fade.
…or the fade

The fault sweep found two causes behind 6 known-failing cells.

- A timed walk read nothing on the way, so a dropped turn or hold showed
  only later as gate_not_seen. run_story_move() now looks after each turn
  and each walk; a look that shows the screen still (the game dropped the
  input) plays that turn or walk once more.
- mash_to_move_hints with press_a_first ended on the party bar under the
  prompt before a late fade, or with the A dropped. It now waits up to 3 s
  after A for a fade or text, and presses A again (3 times at most) while
  the prompt stays with neither.

The row sim shows the screen still on a look with no input taken since
the look before. 03.07d and 03.08 lost_tap and late_fade pass; warp_no_op
stays listed: A again on a prompt after a fade could undo a real warp
that lands at the gate's other side.
…_zone_road

- The row sim's walk to a gate takes its bearing from the step's heading,
  or with none (03.08's walk from the road at 60) from the clean run's
  facing at the walk's start. 03.08 has a gate class case too.
- walk_back_to_zone_road's throw is zone_road_missed (walk_short);
  catch_in_zone stays operation_failed.
- Known failing: 03.07d and 03.08 warp_no_op, each with its likely fix
  (read the minimap's zone green after the fade).
- The white-fade engine test scripts the looks the walk's still checks
  now take.
# Conflicts:
#	SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/Actions/PokemonLZA_AutoStoryScenes.cpp
#	SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/PokemonLZA_AutoStoryEngine_Tests.cpp
03.07d is gone from the story, and with it walk_to_zone_1_start. The sweep
runs 03.08 only; the funnel tolerance, kept for 03.07d's walk into the
nurse's counter, goes too. The gate class case takes 03.06's to_zone_1_gate,
the same step.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant