Repository navigation
Story data codec: run the shared wire cases natively again - #494
Merged
Merged
Conversation
…again StoryDataTests takes the path of a pokesim-story-wire-cases/2 file, reads each case with the native pose, step and checkpoint readers and checks the accept/reject and the record read. The workflow pins PokemonSimulation 4e023f3 (#104, cases in the action-plus-args form) and runs it on all three platforms.
…e fails loudly The standalone main moves to devtools/story-data-tests/StoryDataMain.cpp so program source no longer includes a devtools header; other argument counts print usage and exit 2. The wire-case reader reads a case's own fields outside the try, so a malformed case file throws instead of reading as a rejection. Also plain statements for the verified fields and explicit includes.
dayfine
marked this pull request as ready for review
November 15, 2026 00:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
nav/shared; the diff shows only this change.Runs PokemonSimulation's shared story wire cases through the C++ readers again, now that PokemonSimulation #104 moved them to the action-plus-args form.
StoryDataTests <case file>reads eachpokesim-story-wire-cases/2case with the native pose, declared-pose, step and checkpoint readers, and checks accept/reject and the record read (devtools/story-data-tests/StoryWireCases.cpp). Without an argument it runs the native cases as before.story-data.ymlpins PokemonSimulation 4e023f3 and runs the case file on Linux, macOS and Windows, next to the Python reader; the README links the same revision.Testing: built the standalone codec tests locally (clang,
-Werror);StoryDataTests wire-conformance.jsonpasses 70 of 70 cases, CTest passes 3 of 3, and an edited copy with a wrong expectation fails as expected.