Skip to content

Story data codec: run the shared wire cases natively again - #494

Merged
dayfine merged 2 commits into
nav/sharedfrom
autostory/story-cases-ci
Nov 15, 2026
Merged

dayfine merged 2 commits into
nav/sharedfrom
autostory/story-cases-ci

Conversation

@dayfine

@dayfine dayfine commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Base: nav/shared; the diff shows only this change.

Runs PokemonSimulation's shared story wire cases through the C++ readers again, now that PokemonSimulation #104 moved them to the action-plus-args form.

  • StoryDataTests <case file> reads each pokesim-story-wire-cases/2 case with the native pose, declared-pose, step and checkpoint readers, and checks accept/reject and the record read (devtools/story-data-tests/StoryWireCases.cpp). Without an argument it runs the native cases as before.
  • story-data.yml pins PokemonSimulation 4e023f3 and runs the case file on Linux, macOS and Windows, next to the Python reader; the README links the same revision.

Testing: built the standalone codec tests locally (clang, -Werror); StoryDataTests wire-conformance.json passes 70 of 70 cases, CTest passes 3 of 3, and an edited copy with a wrong expectation fails as expected.

…again

StoryDataTests takes the path of a pokesim-story-wire-cases/2 file, reads
each case with the native pose, step and checkpoint readers and checks the
accept/reject and the record read. The workflow pins PokemonSimulation
4e023f3 (#104, cases in the action-plus-args form) and runs it on all three
platforms.
…e fails loudly

The standalone main moves to devtools/story-data-tests/StoryDataMain.cpp so program source no longer includes a devtools header; other argument counts print usage and exit 2. The wire-case reader reads a case's own fields outside the try, so a malformed case file throws instead of reading as a rejection. Also plain statements for the verified fields and explicit includes.
@dayfine
dayfine marked this pull request as ready for review November 15, 2026 00:08
@dayfine
dayfine merged commit 3cce494 into nav/shared Nov 15, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant