Skip to content

Game languages: FRLG keeps six languages, one Spanish (#312 review) - #495

Merged
dayfine merged 2 commits into
nav/sharedfrom
autostory/languages
Nov 15, 2026
Merged

dayfine merged 2 commits into
nav/sharedfrom
autostory/languages

Conversation

@dayfine

@dayfine dayfine commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Base: nav/shared; the diff shows only this change.

Answers the two open review threads on #312 about Pokemon_GameLanguages.

  • FireRed/LeafGreen keep all six GBA languages: on Switch each language is its own version with no in-game option (Nintendo of America sells English, French and Spanish, the latter two in EU form), and upstream's FRLG programs and test images already cover Japanese and Spanish. The header now says so.
  • The "es" is not a duplicate: each database has one Spanish, and the Gen 8-9 games ship one Spanish (Spain).
  • The header states the rule: every language a game ships in is listed; code that reads text takes the language option and says where it has no reader. The shared AutoStory code already takes the language as a parameter (switch_home_tile_named, StoryRunOptions::LANGUAGE); no code path changes.

Testing: comment-only change; Pokemon_GameLanguages.cpp compiles. Not checked on console.

Answers the #312 review: the Switch FireRed/LeafGreen are the GBA releases
reissued, one version per language with no in-game option, so all six
languages stay (as in upstream's FRLG programs). Gen 8-9 games have one
Spanish, so one "es". Code that reads text takes the language option.
@dayfine
dayfine marked this pull request as ready for review November 15, 2026 00:33
@dayfine
dayfine merged commit 838bf2d into nav/shared Nov 15, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant