Repository navigation
Lab: close the Slice 1 gaps (shot worker, transition source, state.json throttle) - #507
Merged
Merged
Conversation
…on throttle) - ProgramSession's start and stop take an ActionSource and the lab request id, and keep the last transition (ProgramTransitionLatch), latching who stopped the run through STOPPING to STOPPED. The Start/Stop button and integrations pass UI, the lab channel LAB with its request id; the channel no longer infers the source from state changes. - A request of snapshot lines only runs on a second pool worker beside the inbox worker, so a shot never waits behind a long request. - Lab/state.json is rewritten at once on a logical change and otherwise at most once a second (LabStateJsonThrottle).
…de the uuids, request_files replaces next_request_file)
dayfine
marked this pull request as ready for review
November 15, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
lab/tooling(diff shows only this change). Closes the three Slice 1 gaps the #131 review left.ProgramSession::start_program()/stop_program()now take anActionSourceand the lab request id and keep the last transition (ProgramTransitionLatch, newCommonFramework/ProgramTransition.h), latching who stopped a run from STOPPING through STOPPED; the Start/Stop button and integrations passui, the lab channellabwith its request id, so the channel no longer guesses the source from state changes. A request made only ofsnapshotlines (whatshotwrites) now runs on a second pool worker beside the inbox worker, so it never waits behind a long request.Lab/state.jsonis rewritten at once on any logical change (new instance id, finished request, start/stop, video state) and otherwise at most once a second, always with the newest frame.Contract notes for #131: the heartbeat is now ~1 s instead of 500 ms (pa_lab's 10 s limit is unaffected); snapshot-only requests may finish out of name order; JSON values are unchanged.
Tested with new unit tests (ProgramTransition latch, state.json throttle and transition filter, snapshot-request classification, inbox listing); touched files syntax-checked locally, full build and tests on Fork Draft CI. Not run on a console.