Repository navigation
Lab channel: Slice 7b is option B, test the console command gate - #509
Merged
Merged
Conversation
The design doc's Slice 7b said the daemon replaces CFR with an app-wide console seam (option A). The user chose option B on 2026-11-14: each panel keeps its own console, and the seam is the lab channel's existing console commands on the selected, stopped program panel. The section now says so and why, lists what remains (scripts move off CommandFiles/ and LabConsole/, the CFR panel goes once they have), and names the tests that cover the gate. The gate itself moves out of run_console_command's lambda into console_command_refusal(state, reads_only) so the unit test "LabChannel - console command refusal" can cover it: a press is refused in every state but STOPPED, a read runs in any state.
dayfine
marked this pull request as ready for review
November 15, 2026 04:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Slice 7b section of docs/design/Agent-Integration.md described an app-wide console seam (option A); the user chose option B on 2026-11-14, so it now says each panel keeps its own console and the seam is the lab channel's existing console commands on the selected, stopped program panel, with the reasons and what remains (the lab scripts move off CommandFiles/ and LabConsole/, the CFR panel goes once they have). The channel's gate for those commands moves out of a lambda into console_command_refusal() so the LabChannel unit tests cover it: a press is refused in every state but STOPPED, a read runs in any state. Checked with -fsyntax-only on the two touched .cpp files and code health (0 failures); Fork Draft CI runs the unit tests.