Skip to content

Lab channel: Slice 7b is option B, test the console command gate - #509

Merged
dayfine merged 1 commit into
lab/toolingfrom
lab/cfr-retire-b
Nov 15, 2026
Merged

dayfine merged 1 commit into
lab/toolingfrom
lab/cfr-retire-b

Conversation

@dayfine

@dayfine dayfine commented Nov 15, 2026

Copy link
Copy Markdown
Owner

The Slice 7b section of docs/design/Agent-Integration.md described an app-wide console seam (option A); the user chose option B on 2026-11-14, so it now says each panel keeps its own console and the seam is the lab channel's existing console commands on the selected, stopped program panel, with the reasons and what remains (the lab scripts move off CommandFiles/ and LabConsole/, the CFR panel goes once they have). The channel's gate for those commands moves out of a lambda into console_command_refusal() so the LabChannel unit tests cover it: a press is refused in every state but STOPPED, a read runs in any state. Checked with -fsyntax-only on the two touched .cpp files and code health (0 failures); Fork Draft CI runs the unit tests.

The design doc's Slice 7b said the daemon replaces CFR with an app-wide
console seam (option A). The user chose option B on 2026-11-14: each panel
keeps its own console, and the seam is the lab channel's existing console
commands on the selected, stopped program panel. The section now says so
and why, lists what remains (scripts move off CommandFiles/ and
LabConsole/, the CFR panel goes once they have), and names the tests that
cover the gate.

The gate itself moves out of run_console_command's lambda into
console_command_refusal(state, reads_only) so the unit test
"LabChannel - console command refusal" can cover it: a press is refused in
every state but STOPPED, a read runs in any state.
@dayfine
dayfine marked this pull request as ready for review November 15, 2026 04:43
@dayfine
dayfine merged commit 19922bd into lab/tooling Nov 15, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant