Skip to content

pa_lab: describe_program checks each precheck entry (Slice 4) - #512

Merged
dayfine merged 1 commit into
agentsfrom
lab/server-slice-4
Nov 15, 2026
Merged

dayfine merged 1 commit into
agentsfrom
lab/server-slice-4

Conversation

@dayfine

@dayfine dayfine commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Base: agents; the diff shows only this change. Server half of #511 (#131 Slice 4).

describe_program accepted any list under prechecks. It now checks each entry has the shape the app prints in #511, {"name", "needs", "skippable"}, with a non-empty name that appears once, and refuses anything else as app_unavailable, like other malformed replies. The README describes the list. Tested with new table-driven cases in tests/test_app_query.py; the whole lab/server suite passes locally.

A declared precheck list must be entries of {name, needs, skippable} with a
non-empty, unique name; anything else is refused as app_unavailable, like a
bad prechecks field. This is the shape the app prints from fork #511.
@dayfine

dayfine commented Nov 15, 2026

Copy link
Copy Markdown
Owner Author

API review (claude-sonnet-5-5) at 799ecd3: LGTM

The validation matches the README and the #511 shape: each entry needs a non-empty string name, a string needs and a boolean skippable, and names must be unique. unsupported is still accepted, and a malformed list is refused as app_unavailable with the journal in evidence. The new table-driven tests cover each rejection path and the empty-list and ordering cases. I found no bugs or rule violations.

@dayfine
dayfine marked this pull request as ready for review November 15, 2026 06:47
@dayfine
dayfine merged commit be5bfbd into agents Nov 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant