Repository navigation
pa_lab: describe_program checks each precheck entry (Slice 4) - #512
Merged
Merged
Conversation
A declared precheck list must be entries of {name, needs, skippable} with a
non-empty, unique name; anything else is refused as app_unavailable, like a
bad prechecks field. This is the shape the app prints from fork #511.
Owner
Author
|
API review (claude-sonnet-5-5) at 799ecd3: LGTM The validation matches the README and the #511 shape: each entry needs a non-empty string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
agents; the diff shows only this change. Server half of #511 (#131 Slice 4).describe_programaccepted any list underprechecks. It now checks each entry has the shape the app prints in #511,{"name", "needs", "skippable"}, with a non-empty name that appears once, and refuses anything else asapp_unavailable, like other malformed replies. The README describes the list. Tested with new table-driven cases intests/test_app_query.py; the wholelab/serversuite passes locally.