Repository navigation
Conversation
dayfine
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/bp-status
branch
from
October 27, 2026 22:14
57ea3f4 to
78c0050
Compare
dayfine
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/bp-status
branch
from
October 28, 2026 03:43
78c0050 to
e47e69c
Compare
The BP stats are only as good as the balance reads behind them, and a misread or a reroll that cost more than expected would go unnoticed. Each reroll now tells the BBQPointsLedger what it should cost (50 BP for a red quest, 10 for a blue one): a single-slot reroll when it confirms the reroll, and a whole-panel reroll per quest it rerolls. The next successful read must show exactly that drop. A failed read, or an unreadable slot in a whole-panel reroll, skips the check for that window instead of reporting a false mismatch. At the end of a run the farmer logs one line, in red on a mismatch: "BP check: OK. Balance 13694 -> 14044 (change 350), stats net 350. Rerolls expected to cost 30 BP; 3/3 reroll windows matched the reads." If the run stops early, from an error or the Stop button, the line is still logged, as of the last panel read. Add ledger unit tests for matching, mismatched and skipped windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/bp-status
branch
from
October 28, 2026 08:14
e47e69c to
57c0153
Compare
dayfine
added a commit
that referenced
this pull request
Oct 30, 2026
# Conflicts: # SerialPrograms/Source/VideoGames/PokemonSV/Programs/Farming/PokemonSV_BBQSoloFarmer.cpp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Owner
Author
|
Superseded by consolidated Tree 1 PR #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PokemonAutomation/ComputerControl#263.
The BP stats from #16 are built from balance reads, so their net always equals the balance change and can't catch a reroll that didn't happen or a misread balance. Each reroll now tells the ledger what it should cost (50 BP red, 10 BP blue), and the next successful panel read must show exactly that drop; a failed read or an unreadable slot skips that window. At the end of a run the log shows one line, in red on a mismatch, e.g.
BP check: OK. Balance 13694 -> 14044 (change 350), stats net 350. Rerolls expected to cost 30 BP; 3/3 reroll windows matched the reads., and if the run stops early (an error or Stop) the line is still logged as of the last panel read. NewPokemonSV::BBQPointsLedgercases cover matching rerolls, a reroll that cost nothing, a misread and the two unchecked windows; 76 BBQ tests pass on macOS arm64, and the check said OK in three Switch runs (2/2, 3/3, 4/4 windows; S0b, S1b, S1c in STAGE_RUNS.md).🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E