Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…failing list SimSweep: sweep_result() (the log lines and message both games' sweeps print), run_sweep() over SweepVariants, sweep_clean_first() and variant_failure(). SimSeeds: run_seeds() with uint32 seeds, 30 by default, logging mean and worst per measure. KnownFailing: the pass-while-failing wrapper and stale() for entries that name no test. Unit tests for each; adoption in BDSP and FRLG follows per game.
Pokemon Navigation: shared fault sweep runner, seeded rows and known-failing list
…dopt # Conflicts: # SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp # SerialPrograms/cmake/SourceFiles.cmake
The sweeps build SweepVariants for Pokemon::run_sweep(), the wild battles run on run_seeds() (30 seeds, as before), the clean-first rule is sweep_clean_first() and the known-failing list is a Pokemon::KnownFailing, with a new test that every entry names a fault sweep test. Test names and the eight known-failing entries are unchanged.
… 47763e7) Conflict in PokemonFRLG_AutoStoryFaultSweep_Tests.cpp sweep_mount_lost: keep seam4-adopt's Pokemon::sweep_result call with stage20-league's variant count of 1.
make_UNIT_TESTS_ALL() passed the code-health function length limit (50 lines) once the SimSweep, SimSeeds and KnownFailing suites were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #458 (base
frlg/stage20-league) and #464 (nav/leg-trace, merged in for #513's shared runner); the diff also shows #464's commits until it lands in this stack.FRLG's fault sweep carried its own copy of the sweep runner:
SweepFailure/sweep_result(), the clean-first rule, the KNOWN_FAILING wrapper and the 30-seed wild-battle loop. This moves it onto the shared runner from #513: each class now buildsSweepVariants forPokemon::run_sweep(), wild battles run onrun_seeds()(still 30 seeds, now logging mean and worst per measure), the class switch runs undersweep_clean_first(), and the list is aPokemon::KnownFailing. The file keeps only FRLG's rows and how each fault class runs on its sim. Test names and rows are unchanged; the known-failing list keeps its 8 entries, and a new test checks that each entry still names a fault sweep test (KnownFailing::stale()). The only own-commit file isPokemonFRLG_AutoStoryFaultSweep_Tests.cpp; checked by a syntax-only compile with the lab's flags, Fork Draft CI runs the suites.