Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
The shared [Leg] record writer and reader (LegTracer), the fault-file reader for replaying a console failure on a sim (LegReplay), their unit tests, and the Python grader and fault-file tools under devtools/maps. Taken unchanged from the FRLG walker commit and nav/leg-replay (#447) so both games build on one copy. (cherry picked from the shared parts of commit 9499c3f and devtools/maps/leg_replay.py from 98c0b61) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…failing list SimSweep: sweep_result() (the log lines and message both games' sweeps print), run_sweep() over SweepVariants, sweep_clean_first() and variant_failure(). SimSeeds: run_seeds() with uint32 seeds, 30 by default, logging mean and worst per measure. KnownFailing: the pass-while-failing wrapper and stale() for entries that name no test. Unit tests for each; adoption in BDSP and FRLG follows per game.
Pokemon Navigation: shared fault sweep runner, seeded rows and known-failing list
…dopt # Conflicts: # SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp # SerialPrograms/cmake/SourceFiles.cmake # devtools/maps/tests/test_leg_trace.py
…nner The fault sweeps build SweepVariants for Pokemon::run_sweep() under sweep_clean_first(); both known-failing lists are Pokemon::KnownFailing, with a new test that each SimFailureCases entry names a case; the wanderer rows run on run_seeds() (8 seeds, as before). Case names move out of the inputs; test names and the known-failing entries (0 sweeps, 3 cases) are unchanged.
make_UNIT_TESTS_ALL() passed the code-health function length limit (50 lines) once the SimSweep, SimSeeds and KnownFailing suites were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #353 (base
bdsp/story-engine) and #464 (nav/leg-trace, merged in for #513's shared runner); the diff also shows #464's commits until it lands in this stack.BDSP's fault sweep and its console failure cases each carried their own copy of the sweep bookkeeping:
SweepFailure/sweep_result(), the clean-first rule, two known-failing wrappers and the 8-seed wanderer loop. This moves them onto the shared runner from #513: each fault class buildsSweepVariants forPokemon::run_sweep()undersweep_clean_first(), both lists arePokemon::KnownFailing, and the wanderer rows run onrun_seeds()(still 8 seeds). BDSP keeps its rows, its own fault classes and their knobs. Test names and rows are unchanged; the lists keep their entries (0 sweeps, 3 failure cases), and a new test checks that each failure-case entry still names a case. To meet the test-case shape rule, the case names move out of the inputs. Checked by a syntax-only compile with the lab's flags; Fork Draft CI runs the suites.