Repository navigation
Conversation
This was referenced Nov 15, 2026
dayfine
commented
Nov 15, 2026
dayfine
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed SHA: e2e48e9
Verdict
NEEDS_REWORK
First-pass review of this PR's own diff against plza/upstream/s2-08 (#542). The option logic is sound: range order check, verify-mode one-checkpoint and passes <= runs checks, and "no reload at start means no save". Code health: 0 failures. CRLF kept, no banned APIs, files listed in SourceFiles.cmake. Fork Draft CI (ubuntu / build) was still pending when I looked.
Medium
- UI text promises behavior nothing implements.
Pokemon_StoryRunOptions.cppStoryCheckLevel_Database(): "Testing: run each checkpoint 3 times to be sure it really passes". The check level is only handed to the game's steps (check_level()); running a checkpoint N times is Verify Mode. Describe what Testing checks, or drop the claim. - No reader for most of these options anywhere through #545.
RELOAD_AT_START,POSTCONDITIONS_ONLY,CHECKS,LANGUAGE,verify_policy()are read only by tests; no program in the chain constructsStoryRunOptions. The description should say which PR wires them into a program, or the options should land with their first reader. StoryCheckLevel_Database()andStorySaveMode_Database()(Pokemon_StoryRunOptions.cpp:13-34) are external-linkage functions declared in no header. Put them in the file's unnamed namespace (TotW #186), or declare them next to their enums if other code needs them.
Low
- Options tests are split across two homes.
test_run_options,test_verify_optionsandtest_checkpoint_dropdownswere added toPokemon/AutoStory/Pokemon_StoryStepExecutor_Tests.cpp, while this PR also addsPokemon_StoryRunOptions_Tests.cppandPokemon_StoryRangeOptions_Tests.cpp. Move them next to the options they test. Pokemon_StoryStepExecutor_Tests.cpptest_run_options: the comment and failure text say "Thorough checks by default", but the check (correctly) expectsStoryCheckLevel::DEFAULT. The message also mentions "no stop at the first failure", which nothing checks.Pokemon_StoryRunOptions.h:99refers toStoryLaunchRequest::Running::RESTART/Running::KEEP, which arrive only in #545. Reword without the type, or note where it comes from.- Question:
Pokemon_GameLanguages.hsays the Gen 8-9 games "have one Spanish (Spain)". I believe Legends: Z-A added Latin American Spanish. If so, the comment should say so even thoughLanguagehas no enum value for it yet. Pokemon_StoryRunOptions_Tests.cpp:const ReloadAtStartCase m_case;withstd::moveinto it. Drop theconst(the move is a copy anyway), as the other test classes in the chain do.
# Conflicts: # SerialPrograms/Source/Pokemon/AutoStory/Pokemon_AutoStory_Tests.h # SerialPrograms/Source/Pokemon/AutoStory/Pokemon_StoryStepExecutor_Tests.cpp
…ses file-local The Testing check level said it runs each checkpoint 3 times, which is verify mode's job; the text now says what it checks. The two dropdown databases are declared in no header, so they move into the unnamed namespace. Also finishes the executor test table merge.
Owner
Author
|
Review fixes, tip Fixed: 1 (Testing no longer claims 3 runs), 2 (description names the PLZA program PR, batch 2), 3 (the two databases are in the unnamed namespace). |
Owner
Author
# Conflicts: # SerialPrograms/Source/Pokemon/AutoStory/Pokemon_AutoStory_Tests.h
One input is left for saving: the row's execution.save, plus the attempts per checkpoint.
PLZA keeps its own Game Language option.
# Conflicts: # SerialPrograms/cmake/SourceFiles.cmake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #542
Adds the options every AutoStory program shows: the language dropdowns per game, the start/end checkpoint range with its order check, and the run policy (how hard to try, check level, language, when to save) with the StoryCheckLevel type it chooses from read into the shared segment policy, plus story_checkpoint_database() for the range dropdowns. No program in this chain constructs StoryRunOptions: Used by the PLZA program PR (batch 2). Tests: the StoryRangeOptions, StoryRunOptions and AutoStorySelect suites and the StoryStepExecutor cases that read run options, built and run by Fork Draft CI. Part of the re-split of #522/#524/#525 into reviewable steps; review fixes are new commits on the PR that owns each problem, merged up the chain.