Repository navigation
Conversation
ControlPlane.begin_action stores a leased call once with the lease check; the pending ticket remembers the app instance (migration 2) and observe resolves it from the app's terminal transition. stop_program sends a fixed owner/request/claim/stop request; the channel owner comes from the config.
…ce 5b) cfr.py checks every line (controller and screen-read commands only, bounded numbers, a 60 s worst case) before anything is stored or sent. cfr_batch needs a stopped program, a ready controller and live video, marks the save fact stale (cfr_batch) before sending, and returns the app's journal. A retry collects a pending batch; an app restart fails it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #518
Base
agents. Until #518 merges, the diff also shows #518's commit (4334cc5); this PR's own change is 1aacde2.Slice 5b from #131 adds
cfr_batch, the debug-only console batch, as a leased action. It sends lines the allowlist (pa_lab/cfr.py) accepts as one channel request, using #518's owner/request/claim lines, and returns the app's journal.console://B/saveis marked stale (cfr_batch) before anything is sent, and the mark survives a daemon restart. Tested with thelab/serverunit tests (184, 26 of them new, all against the fake lab): every allowed and refused line form, the refusals, the journal outcomes, save staleness, retries, daemon and app restarts, a busy app and a foreign channel owner. No console or app was touched.Decisions taken (each picks the conservative option; overturn any of them):
press dpad stick wait taps walk) and screen reads (shot shots detect wait_for expect game_open). Refused: every channel command,close_game,history,snapshot,state, game-registered commands, comments, blank lines and lines not in canonical form. TheCAPTUREbutton and theimageargument (a file path) are refused too.stop_program's.stoppedon a program panel, controllerready, videolive. Bad lines and a bad app state get a storedrefusedrecord, so they appear in the audit log.knownsave.expecttimeout, say) iscompletedwithoutcome: line_failedandfailed_line, notfailed: the journal is the answer. Only a refusal on the owner lines isfailed, withapp_unavailable.refused,timeout) if still in the inbox; if the app took it, the record isfailed,timeout("may have run in part"). A retry of a ticket left pending by a daemon stop collects the journal; an app restart fails it.shotfor an image).