Repository navigation
FRLG AutoStory 16.03: re-anchored last leg ends facing as planned (rival trigger) - #548
Merged
Merged
Conversation
…facing west after a re-anchor
… that leg did
The way back after finding the player at walls was planned to the leg's end
tile with no facing, so it ended with its own last leg's facing ("north 1
(to wall)") while the route still reported the planned one (west). 16.03's
rival_trigger step then tapped west with no turn first, which only turned the
player beside the trigger (2, 4). plan_reanchor() now takes the facing the way
back must end with; the walker passes the leg's own when nothing follows it.
dayfine
marked this pull request as ready for review
November 15, 2026 08:54
dayfine
added a commit
that referenced
this pull request
Nov 15, 2026
…Giovanni Red here: the open-leg check on below_giovanni's last leg, north 3 to (2, 3), finds the player at walls and its way back ends "west 1", so the walk ends facing west. The re-anchor's end facing comes with #548.
dayfine
added a commit
that referenced
this pull request
Nov 15, 2026
The sim's north facing on (19, 13) was the same re-anchor as 17.03's: the open-leg check on mansion_holes' last leg, south 10, found the player at walls and the way back ended "north 1". With #548's end facing it ends facing south. No endpoint exemption is left for it or 17.03.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
frlg/stage20-league(after #514); the diff shows only this change.Fixes 16.03's rival scene never starting (console B, 2026-11-15 00:28, run 5:
rival: no_battle class=screen_unread).to_rival_trigger's last leg "west 2 (open)" from 7F's pad (5, 4) got an open-leg position check, which found the player at walls and walked back, ending on "north 1 (to wall)" at (3, 4) facing north. The route still reported the planned facing, west.rival_triggerthen tapped west with no turn first, which only turned the player. They never stepped onto the trigger (2, 4) (pokefirereddata/maps/SilphCo_7F/map.jsoncoord_events (2, 4)/(2, 5),VAR_MAP_SCENE_SILPH_CO_7F == 0,SilphCo_7F_EventScript_RivalTriggerTop). The failure frame shows the rival still on his spawn tile (2, 6).plan_reanchor()now takes the facing the way back must end with. The walker passes the stopped leg's own facing when nothing follows it, so the way back ends with a turn west.Testing: new sim test in the AutoStory Silph suite (
16.03 the walk to the rival's trigger, found again at walls) walks 7F's pad to (3, 4) on the overworld sim. It checks that the re-anchor ran and the walk ends facing west. Touched files syntax-checked locally with the build's flags; CI runs the suites.