Repository navigation
Conversation
…red end A case per checkpoint walks its row on the overworld sim from its start and checks the end tile and facing its plan declares (checkpoint_end_pose()); the coverage test holds every checkpoint of the story table to a case or an exemption with its reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
frlg/stage20-league(after #514). The diff shows only this change.The user asked whether every FRLG AutoStory checkpoint has a simulation of its endpoint; 16 had none. This adds one generic case per checkpoint: it walks the row on the overworld sim from its start (walks and trainer battles on the sim, scenes, talks, Fly and heals moved to their declared pose) and checks the end tile and facing the plan declares (
checkpoint_end_pose()). A coverage test holds every checkpoint of the story table to a case or a commented exemption. 70 checkpoints have cases, 23 are exempt: no start or no declared end (01.01, rows ending on LEGS taps), walks with state the generic walker lacks (gates, card keys, boulders, Cut, Surf), each pointing at its own test, and five red findings: 17.02 and 10.04 (the sim turns the player toward a trainer who walks up; pokefirered'sTrainerSeeFunc_PrepareToEngagedoes not, so the plans' facing stands), 17.03 (Takashi in the way, already known), 06.03 (ends on (5, 4), plan says (5, 3)) and 13.01 (sim ends facing north, plan says south). Tested with the headless runner on the endpoint suite locally (71 passed); no plan or map data changed.