Skip to content

FRLG AutoStory: battle text box by its frame in the screen observer - #552

Draft
dayfine wants to merge 3 commits into
frlg/stage20-leaguefrom
frlg/observer-battle-check
Draft

dayfine wants to merge 3 commits into
frlg/stage20-leaguefrom
frlg/observer-battle-check

Conversation

@dayfine

@dayfine dayfine commented Nov 15, 2026

Copy link
Copy Markdown
Owner

On Silph Co. 5F the screen observer reported BATTLE_STARTED before every step (about 15 s lost each, 16.02/16.03). BattleDialogDetector's two blue boxes also pass on the near-black (7, 7, 7) below a small map. FrlgScreenObserver and read_text_screen() now use BattleTextBoxDetector, which also needs the box's white line and gold band; other FRLG programs keep BattleDialogDetector. New image tests in AutoStoryScreenEvents run the observer on the Silph Co. 5F frame and on the existing BattleTextBoxDetector frames. The Silph frame goes to dayfine/CommandLineTests (branch frlg/observer-battle-check), and the CI pin moves to that commit. A Python copy of both detectors reads the 5F frame as a battle with the old check and not with the new one.

dayfine and others added 3 commits November 15, 2026 01:13
FrlgScreenObserver's BATTLE_STARTED and read_text_screen() used
BattleDialogDetector, whose two blue boxes also pass on the near-black
(7, 7, 7) below a small map: Silph Co. 5F read as a battle before each
step in 16.02/16.03. They now use BattleTextBoxDetector, which also needs
the box's white line and gold band. Other FRLG programs keep
BattleDialogDetector.

Image tests replay the Silph Co. 5F frame (new in the fork's
CommandLineTests; pin bumped) and the BattleTextBoxDetector frames through
the observer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant