Repository navigation
Conversation
FrlgScreenObserver's BATTLE_STARTED and read_text_screen() used BattleDialogDetector, whose two blue boxes also pass on the near-black (7, 7, 7) below a small map: Silph Co. 5F read as a battle before each step in 16.02/16.03. They now use BattleTextBoxDetector, which also needs the box's white line and gold band. Other FRLG programs keep BattleDialogDetector. Image tests replay the Silph Co. 5F frame (new in the fork's CommandLineTests; pin bumped) and the BattleTextBoxDetector frames through the observer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Silph Co. 5F the screen observer reported BATTLE_STARTED before every step (about 15 s lost each, 16.02/16.03). BattleDialogDetector's two blue boxes also pass on the near-black (7, 7, 7) below a small map. FrlgScreenObserver and read_text_screen() now use BattleTextBoxDetector, which also needs the box's white line and gold band; other FRLG programs keep BattleDialogDetector. New image tests in AutoStoryScreenEvents run the observer on the Silph Co. 5F frame and on the existing BattleTextBoxDetector frames. The Silph frame goes to dayfine/CommandLineTests (branch frlg/observer-battle-check), and the CI pin moves to that commit. A Python copy of both detectors reads the 5F frame as a battle with the old check and not with the new one.