Repository navigation
Conversation
Owner
Author
|
API review (claude-sonnet-5-5) at 0dade67: changes_requested The program wiring is mostly sound. The verify path returns early and never runs GO_HOME_WHEN_DONE, which is a behavior bug. The range check throws a misleading message for one of its two conditions. The rest is style: a new bool parameter, a duplicated policy branch, and the checkpoint list being read from two sources.
|
… split; capture option A verify run returned after its notification without GO_HOME_WHEN_DONE. An out-of-range checkpoint index got the start-after-end message; it now has its own. Save Screen Captures (off by default) turns on the backend's frame captures (StoryEnv::capture_looks). run_policy() builds the policy once, start_from() takes the option rather than a bool, and the includes are sorted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #568
Adds the "Auto Story" program for Pokemon Legends: Z-A to the Public Betas panel list: it runs the checkpoints from the start one to the end one with the shared run options (verify, save mode, reload at start), on the built-in plans. The user picks the new game's language, look and name by hand; 01.00 starts on the Confirm Choices screen that follows. No new unit suite; the program is the story game of #568 on the console backend of #559.