Repository navigation
Conversation
… story dialog, Confirm Choices) PlatformArrivalDetector with its built-in reference (ReferenceData/plza-platform.json, embedded by cmake/EmbedTextFiles.cmake), AutosaveDetector and its pixel shares, AdvanceArrowDetector, StoryDialogDetector (with FlatWhiteDialogDetector::detect_box() for the box while its text types) and the Confirm Choices reader, with their unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #574
PLZA slice 1 needs to read the new game's Confirm Choices screen, the station platform once the opening ends, the autosave badge, the advance arrow and the story's dialog box; this adds those detectors (ConfirmChoicesReader, PlatformArrivalDetector with its reference data, AutosaveDetector, AdvanceArrowDetector, StoryDialogDetector and their pixel-share helpers), plus a box-only check on the existing FlatWhiteDialogDetector. They are copied from the PLZA AutoStory branch and trimmed to slice 1, with the banner, controls-hint, skip-prompt and later detectors left out. Tests read synthetic frames and console frames from dayfine/CommandLineTests #18, which CI is pinned to here; no console run.