Repository navigation
Conversation
The choice box (the selection arrow in the dialogue's choice area, and a reader for its rows), text_to_choice and choose_0/choose_1 on the story backend, mash_to_move_hints' min_length_ms, load_checkpoint_start (the latest save, refused when it is the station platform but the row starts later), and run_plza_segments for reload_when_chained rows (Pokemon::story_run_segments). A row that the game does not save at now logs "[Save] 01.01: not saved (save unverified)" (Pokemon::NOT_SAVED). 01.00 ends on an autosave: run logs show the badge on the platform.
dayfine
added a commit
that referenced
this pull request
Nov 15, 2026
Brings the reviewed slice chain (#572-#582) into the long-lived branch. Where both sides add the same file, plza/autostory's later version is kept and the slices' review fixes are applied on top: StoryRangeOptions moves to Pokemon/AutoStory/Options with #572's review fixes, SV takes the slices' version, the shared Outcome and Pose functions move to their own .cpp files, and add_tests_AutoStory() also registers the slices' new suites (StoryBackend, CheckpointAttempts, ScreenMachine, PLZA AutoStoryDialogDetector). The slices' PLZA AutoStoryGame tests are left out: they are written against the slices' smaller game API (make_plza_story_game_without_console(), unverified autosaves), which this branch has not adopted; its AutoStoryEngine tests cover the same game. The nine AutoStoryScreenEvents frames missing from CommandLineTests #18 are skipped as pending a recapture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #580 (base plza/slice2/a; the diff shows only this change).
Checkpoint 01.02 needs the choice box: the scene machine can now stop at it (text_to_choice, B through the text), and choose_0/choose_1 move the highlight with the D-pad by the choice rows reading and press A, on the story backend, so FakeStoryBackend tests cover them. A run that starts after 01.01 now loads the latest save with load_checkpoint_start(), which stops when that save is still the station platform, and rows marked reload_when_chained reload there (shared Pokemon::story_run_segments(); no row sets it yet, since 01.01's autosave is unverified). Rows the game does not save at log "[Save] 01.01: not saved (save unverified)" instead of "save failed", and 01.00 is now "autosave" (the run log showed the badge on the platform).
Tested with unit tests on Fork Draft CI: StoryFiles segments, StoryEngine save lines, PLZA AutoStoryGame run/load/chain, scene machine, and the choice rows reader on synthetic menus plus CommandLineTests frames (the tourist, the bag scene, the elevator, light pavement). za2_m3w_s2 is not in CommandLineTests, so the old screen-events choice test is skipped; ArrivalToAd 0065 checks the choice box instead. Not run on the console yet.