Skip to content

FRLG AutoStory: flag story routes that cross a tile twice - #583

Draft
dayfine wants to merge 1 commit into
frlg/shopping-prepfrom
frlg/route-revisit
Draft

dayfine wants to merge 1 commit into
frlg/shopping-prepfrom
frlg/route-revisit

Conversation

@dayfine

@dayfine dayfine commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Depends on #579

The user's rule of thumb: a route that crosses the same tile twice is a red flag. Nothing checked that for the story's planned routes. revisited_tiles() lays a planned route out tile by tile (leg_tiles(), warp and spinner ends, Surf landings, gates as the route changes them) and lists the tiles it steps on again. A new AutoStory test fails on any story route that does this, except the ones in ALLOWED_REVISITS, each with a one-line reason.

All nine routes that do it today are allowlisted. Four are real counter-examples: the Mansion switch go-and-returns in 13.03 and 13.04, and the wall clips that place the player (12.03 on Route 21's water, 19.03 after 16 grass tiles). Five are cost choices that need re-weighing, marked as such: 13.01, 16.02/16.03 (the 9F teleporter step-off held to the wall), 19.04b (out of Victory Road and straight back in) and 19.04c. No plan changed, because fixing those means new route costs, which would move console-verified plans. Fixed legs steps are not checked yet. Tested with the OverworldRoute suite (new revisited_tiles cases) and the AutoStory suite on Fork Draft CI; the walked side is graded from run logs by dayfine/PokemonSimulation#107.

revisited_tiles() lays a planned route out tile by tile (leg_tiles(), warp
and spinner ends, Surf landings, gates as the route changes them) and lists
the tiles it steps on again. The story plan test collects them per route
step; a new test fails on any route that walks back over its own way,
except the nine in ALLOWED_REVISITS, each with its reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant