Repository navigation
Conversation
revisited_tiles() lays a planned route out tile by tile (leg_tiles(), warp and spinner ends, Surf landings, gates as the route changes them) and lists the tiles it steps on again. The story plan test collects them per route step; a new test fails on any route that walks back over its own way, except the nine in ALLOWED_REVISITS, each with its reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #579
The user's rule of thumb: a route that crosses the same tile twice is a red flag. Nothing checked that for the story's planned routes.
revisited_tiles()lays a planned route out tile by tile (leg_tiles(), warp and spinner ends, Surf landings, gates as the route changes them) and lists the tiles it steps on again. A new AutoStory test fails on any story route that does this, except the ones inALLOWED_REVISITS, each with a one-line reason.All nine routes that do it today are allowlisted. Four are real counter-examples: the Mansion switch go-and-returns in 13.03 and 13.04, and the wall clips that place the player (12.03 on Route 21's water, 19.03 after 16 grass tiles). Five are cost choices that need re-weighing, marked as such: 13.01, 16.02/16.03 (the 9F teleporter step-off held to the wall), 19.04b (out of Victory Road and straight back in) and 19.04c. No plan changed, because fixing those means new route costs, which would move console-verified plans. Fixed
legssteps are not checked yet. Tested with the OverworldRoute suite (new revisited_tiles cases) and the AutoStory suite on Fork Draft CI; the walked side is graded from run logs by dayfine/PokemonSimulation#107.