Skip to content

FRLG AutoStory: Fly to every Center trip from 10.01 on - #586

Draft
dayfine wants to merge 3 commits into
frlg/shopping-prepfrom
frlg/fly-to-center
Draft

dayfine wants to merge 3 commits into
frlg/shopping-prepfrom
frlg/fly-to-center

Conversation

@dayfine

@dayfine dayfine commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Depends on #579 (base `frlg/shopping-prep`; the diff shows only this change).

Once the Pidgey knows Fly (10.01), several Center trips still walked across town: 14.04b (79 tiles from Celadon Gym through the regrown yard tree), 15.01 (35 tiles from Route 7's gate round Saffron's Grunts), 17.04b (58 tiles round Viridian's fences) and 18.02b (about 40 tiles back over Saffron Gym's four pads). A new lint test plans every row from 10.01 on and fails any Center trip that walks more than 20 tiles after its last Fly, or that walks out of a building where an Escape Rope works (pokefirered allow_escaping). Its allowlist, with reasons, is Cinnabar's two walks (14.01, 14.02b) and Indigo Plateau (19.05, no Fly point until the player steps on it). The four rows now exit to the nearest outdoor tile (18.02b: Escape Rope from Sabrina's room, ropes 3 to 2) and Fly; the Center script steps are unchanged. Plan goldens and the rows' sim tests are updated by hand from the old plans; CI runs them. All four rows need console re-checks.

The user's rule (2026-11-15): once the Pidgey knows Fly (10.01), every
trip to a Pokemon Center flies unless the Center is really close, such as
Cinnabar Gym to Cinnabar's Center. The new test plans each row's routes
from its start and checks each trip that ends at a Center step or in
front of a Center's door: no more than 20 tiles walked after its last
Fly, and a trip out of a building an Escape Rope works in (pokefirered
map.json allow_escaping) leaves it by rope when the walk out is longer.
Cinnabar's two walks and Indigo Plateau (no Fly point before the player
steps onto it) are allowed, with reasons.

It fails for now on 14.04b, 15.01, 17.04b and 18.02b.
The Center trips the new lint flags, each now ending in a Fly to the
town's heal spot below the Center's door and a turn to face it; the
Center script step is unchanged.

- 14.04b walked 79 tiles from Celadon Gym round the yard, through the
  regrown tree (40, 35) and up through the city. It now goes out of the
  gym's door onto (11, 31) and flies; the tree is left standing.
- 15.01 walked 35 tiles from Route 7's gate guard round Saffron's Rocket
  Grunts. It now steps out of the gate onto Saffron (8, 27), which makes
  Saffron a Fly point (SaffronCity's setworldmapflag), and flies.
- 17.04b walked 58 tiles from Viridian Gym's door north round the city's
  fences for a straight line of 26. It now flies from the door.
- 18.02b walked about 40 tiles over Saffron Gym's four pads to its door.
  SaffronCity_Gym allows an Escape Rope (pokefirered map.json), so it now
  ropes out from Sabrina's room to below the gym's door (46, 13), where
  16.06b's walk in set the escape warp, and flies. The bag's ropes go
  from 3 to 2.

The plan goldens lose the walks and gain the short exits and turns; the
sim tests of these rows run the Fly (and 18.02b's rope), and 18.02b's
direct-walk test now expects nothing walked.
PokemonFRLG_AutoStoryRows_Tests.h was over code health's header symbol
limit with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant