Skip to content

Code health: parameter comments and test-only header exposure advisories - #597

Merged
dayfine merged 1 commit into
agentsfrom
agents-lint-param-comments
Nov 16, 2026
Merged

dayfine merged 1 commit into
agentsfrom
agents-lint-param-comments

Conversation

@dayfine

@dayfine dayfine commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Base: agents; independent, the diff shows only this change.

The user keeps asking in reviews (#590) for parameter comments on literal arguments, for no test-only header exposure and for no vacuous tests. This adds two Code Health advisories, param_comment (param_comments.py: uncommented literal arguments in calls of 3+ arguments) and test_only_api (exposure.py: public names a header adds that only tests or its own .cpp use), with allow tags, and puts all three rules in the autostory-code and reviewer definitions.

Both are advisory: on 18 fork PRs param_comment reported 379 calls (257 in test files, 91 controller timings), and on the PLZA stack about half of the test_only_api names gained a real caller one PR later. Both report exactly the sites the #590 and #572 reviews changed. Tested with the code_health self-tests (154 pass) and the harness checks.

…on vacuous tests

param_comments.py reports uncommented literal arguments in calls of 3+ arguments;
exposure.py reports public header names that only tests or their own .cpp use.
Both advisory, with tags. autostory-code and reviewer get the three review rules
from fork #590.
@dayfine
dayfine marked this pull request as ready for review November 16, 2026 01:17
@dayfine
dayfine merged commit 4471875 into agents Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant