Repository navigation
Code health: parameter comments and test-only header exposure advisories - #597
Merged
Merged
Conversation
…on vacuous tests param_comments.py reports uncommented literal arguments in calls of 3+ arguments; exposure.py reports public header names that only tests or their own .cpp use. Both advisory, with tags. autostory-code and reviewer get the three review rules from fork #590.
dayfine
marked this pull request as ready for review
November 16, 2026 01:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
agents; independent, the diff shows only this change.The user keeps asking in reviews (#590) for parameter comments on literal arguments, for no test-only header exposure and for no vacuous tests. This adds two Code Health advisories,
param_comment(param_comments.py: uncommented literal arguments in calls of 3+ arguments) andtest_only_api(exposure.py: public names a header adds that only tests or its own .cpp use), with allow tags, and puts all three rules in theautostory-codeandreviewerdefinitions.Both are advisory: on 18 fork PRs
param_commentreported 379 calls (257 in test files, 91 controller timings), and on the PLZA stack about half of thetest_only_apinames gained a real caller one PR later. Both report exactly the sites the #590 and #572 reviews changed. Tested with the code_health self-tests (154 pass) and the harness checks.