Skip to content

pa_lab: preflight_program, options bound to its token, cfr_batch (Slice 5b) - #600

Draft
dayfine wants to merge 11 commits into
lab/server-slice-5afrom
lab/server-slice-5b
Draft

dayfine wants to merge 11 commits into
lab/server-slice-5afrom
lab/server-slice-5b

Conversation

@dayfine

@dayfine dayfine commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Depends on #592. Base lab/server-slice-5a; this branch also merges origin/agents (for the guide/ user pages), so until #592 picks up agents the diff shows those agents commits too.

Slice 5b of #131, server side. preflight_program reads describe_program, refuses unknown keys, wrong types, out-of-range values and disabled enum entries before anything is sent, refuses programs without a precheck list, then sends a proposed preflight <JSON> app command and turns its reply into a precheck_failed / prechecks_unsupported / invalid_arguments refusal or a token. The token is bound to the app instance, panel, options hash, last start/stop, save status (and the newest cfr_batch) and the lease, lives 120 s, and run_program requires it again (contract field back to required) and sends set lines for the options before start. cfr_batch reuses #547's allowlist, needs the lease and a stopped program, and marks console://B/save stale before writing the request.

No app change: the app has no way to run a program's prechecks without starting it (lab/tooling has only the summaries, and a check needs a running program's environment), which is more than a channel command, so the app side is described in the README and only the fake app implements preflight. On today's app every preflight fails, so no run can start through the server.

Tested with the fake lab: python3 -m unittest discover -s lab/server/tests -t lab/server (187 tests; new suites test_preflight, test_cfr_batch, test_cfr), plus the harness checks. User pages guide/actions.md and guide/start-checks.md and GUIDE.md updated; examples are fake-app output.

dayfine and others added 11 commits November 15, 2026 17:00
pa-lab: draft user pages for the planned features
pa-lab user pages: examples for each tool
…on vacuous tests

param_comments.py reports uncommented literal arguments in calls of 3+ arguments;
exposure.py reports public header names that only tests or their own .cpp use.
Both advisory, with tags. autostory-code and reviewer get the three review rules
from fork #590.
Code health: parameter comments and test-only header exposure advisories
# Conflicts:
#	lab/server/GUIDE.md
#	lab/server/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant