Repository navigation
Conversation
pa-lab: draft user pages for the planned features
pa-lab user pages: examples for each tool
…on vacuous tests param_comments.py reports uncommented literal arguments in calls of 3+ arguments; exposure.py reports public header names that only tests or their own .cpp use. Both advisory, with tags. autostory-code and reviewer get the three review rules from fork #590.
Code health: parameter comments and test-only header exposure advisories
# Conflicts: # lab/server/GUIDE.md # lab/server/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #592. Base
lab/server-slice-5a; this branch also mergesorigin/agents(for theguide/user pages), so until #592 picks up agents the diff shows those agents commits too.Slice 5b of #131, server side.
preflight_programreadsdescribe_program, refuses unknown keys, wrong types, out-of-range values and disabled enum entries before anything is sent, refuses programs without a precheck list, then sends a proposedpreflight <JSON>app command and turns its reply into aprecheck_failed/prechecks_unsupported/invalid_argumentsrefusal or a token. The token is bound to the app instance, panel, options hash, last start/stop, save status (and the newestcfr_batch) and the lease, lives 120 s, andrun_programrequires it again (contract field back to required) and sendssetlines for the options beforestart.cfr_batchreuses #547's allowlist, needs the lease and a stopped program, and marksconsole://B/savestale before writing the request.No app change: the app has no way to run a program's prechecks without starting it (lab/tooling has only the summaries, and a check needs a running program's environment), which is more than a channel command, so the app side is described in the README and only the fake app implements
preflight. On today's app every preflight fails, so no run can start through the server.Tested with the fake lab:
python3 -m unittest discover -s lab/server/tests -t lab/server(187 tests; new suites test_preflight, test_cfr_batch, test_cfr), plus the harness checks. User pages guide/actions.md and guide/start-checks.md and GUIDE.md updated; examples are fake-app output.