Repository navigation
Conversation
dayfine
added a commit
that referenced
this pull request
Nov 16, 2026
…from the marker walk_toward_marker() and walk_back_from_marker() walk until the objective marker's distance reads a given value; moved here from #604 so this PR owns MarkerWalk's code.
Name the drawn plate boxes in the caught-mark tests, comment the filter range arguments, and keep party_bar_filled_slots in the detector's .cpp, since only its tests call it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #598 (base
plza/slice5); the diff shows only this change.Slice 5b of the lean PLZA AutoStory chain: checkpoint 03.08, the last piece of plza/autostory's story the chain did not cover. 03.08 patrols Wild Zone 1's road between the catch spots at 100 and 60 (by the objective marker), throws only at lock-on targets whose name plate shows no caught mark, and is done when the party bar shows 5 filled slots. Each catch autosaves, and the run logs showed that autosave mid-checkpoint, so the checkpoint is split there: 03.08 (the catches, autosave) and 03.08b (back to the road, face heading 265 on the minimap and run to the far gate with the existing
run_to_gate, then out with upstream'sleave_zone_gate; no save). Ported from plza/autostory: the caught-mark reader and the party bar detector. Left out: the lock-on bracket watch and sweep, nearest-target choice and walk-up, the throw-again-after-a-miss logic, the Registered! banner tally and species check, and the far gate's pillar reader (the run is steered by heading only). The stop-at-distance marker walk (toward and back) it uses lives in #598, which owns the marker walk files.Tests: synthetic-frame tests for the caught-mark reader, the party bar's frame tests (frames are in the fork's CommandLineTests only), and the story data and console-only run cases for 03.08/03.08b. No console run yet.