Skip to content

code health: rules for systematic fixes (learned rule needs a test, no special cases by name, plan lint) - #612

Merged
dayfine merged 1 commit into
agentsfrom
agents-code-health-systematic
Nov 16, 2026
Merged

dayfine merged 1 commit into
agentsfrom
agents-code-health-systematic

Conversation

@dayfine

@dayfine dayfine commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Base: agents. Independent; the diff shows only this change.

Adds the three rules the user approved as blocking code-health checks: a comment citing a console B finding needs a test or ConsoleFailures replay that cites the same date (and checkpoint), and removing the last such test fails; AutoStory C++ may not compare or look up checkpoint ids or plan event ids; a new or edited legs event in any game's plan needs "not planned: " in its why. Each is incremental against the base, and the two C++ rules take a justified code-health: allow tag at the site.

Self-tests: 172 pass (17 new in test_systematic.py). On the diffs of #599, #604 and #610 the rules report nothing; on the commit that first added 17.03's hand-written legs (0bfb41f) plan lint reports exactly its four legs events. Whole-tree numbers and the limits of the date match are in the README's new "Systematic fixes" section.

…ial cases by name, plan lint)

Three blocking checks for the user's 2026-11-15 ask to keep fixes systematic:
- learned_rule_test: a console B citation in non-test C++ needs a test or
  ConsoleFailures replay citing the same date (and checkpoint), same game or
  shared; also fails when a change removes the last such test.
- special_case: checkpoint ids and plan event ids used as keys in AutoStory C++.
- plan lint: new or edited legs events in any StoryData plan need
  "not planned: <reason>" in their why.
@dayfine
dayfine marked this pull request as ready for review November 16, 2026 06:27
@dayfine
dayfine merged commit 21e19d3 into agents Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant