Repository navigation
Conversation
Adds the naming screen keyboard from pret/pokefirered's naming_screen.c (three pages, the button column, wrap-around and page-change cursor rules), a planner that turns a name into the fewest presses, a type_name() routine that presses them, and a detector for the screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
added a commit
that referenced
this pull request
Nov 1, 2026
…eyboard The first console run went back to the controls pages: they read as a message box without an arrow, so after two presses the intro took them for the keyboard and pressed B, which in the intro goes back a page. Now a message box gets A every 1.5 s whatever it shows, and the empty name is entered only when the naming screen is detected. The naming screen detector is the one from frlg/naming-screen (fork #81), unchanged; on the lab's 331 captures it fires on the five keyboard shots and nothing else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
plan_naming_keys() plans the presses that type a name and stops before START A; plan_naming_input() is now that plan plus START A. type_name_without_confirming() types the name and leaves the naming screen open, which is where SID Helper starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This was referenced Nov 2, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Conflict in the registration lists (SerialPrograms/Source/VideoGames/PokemonFRLG/PokemonFRLG_Tests.cpp ): kept both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FRLG has no code for its naming screen yet, and AutoStory needs it to name the player and the rival, and later for nicknames. This adds the keyboard from pret/pokefirered's
naming_screen.cas plain data: all three pages, the page/back/OK column, and the cursor's wrap-around and page-change rules. On top of that is a pure planner that turns a name into the fewest presses, ending with START and A, andtype_name(), which checks that the naming screen is up and then presses the plan. The detector's boxes and colors come from the decomp and the press timings are estimates; neither has been tried on a Switch yet.plan_naming_keys()andtype_name_without_confirming()type a name and leave OK unpressed, for SID Helper, which confirms the name on its own timing;plan_naming_input()is now that plan plus START A, with a "keys only" test (added in 47c3ffc, CI dispatched: https://github.com/dayfine/Arduino-Source/actions/runs/41528871266). The new PokemonFRLG::NamingScreen unit tests (cursor moves, plans, name checks) pass in fork CI on Mac, Windows Clang and Ubuntu.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E