Skip to content

FRLG: type names on the in-game naming screen - #81

Draft
dayfine wants to merge 10 commits into
mainfrom
frlg/naming-screen
Draft

dayfine wants to merge 10 commits into
mainfrom
frlg/naming-screen

Conversation

@dayfine

@dayfine dayfine commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

FRLG has no code for its naming screen yet, and AutoStory needs it to name the player and the rival, and later for nicknames. This adds the keyboard from pret/pokefirered's naming_screen.c as plain data: all three pages, the page/back/OK column, and the cursor's wrap-around and page-change rules. On top of that is a pure planner that turns a name into the fewest presses, ending with START and A, and type_name(), which checks that the naming screen is up and then presses the plan. The detector's boxes and colors come from the decomp and the press timings are estimates; neither has been tried on a Switch yet. plan_naming_keys() and type_name_without_confirming() type a name and leave OK unpressed, for SID Helper, which confirms the name on its own timing; plan_naming_input() is now that plan plus START A, with a "keys only" test (added in 47c3ffc, CI dispatched: https://github.com/dayfine/Arduino-Source/actions/runs/41528871266). The new PokemonFRLG::NamingScreen unit tests (cursor moves, plans, name checks) pass in fork CI on Mac, Windows Clang and Ubuntu.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine and others added 2 commits October 29, 2026 23:45
Adds the naming screen keyboard from pret/pokefirered's naming_screen.c
(three pages, the button column, wrap-around and page-change cursor
rules), a planner that turns a name into the fewest presses, a
type_name() routine that presses them, and a detector for the screen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine added a commit that referenced this pull request Nov 1, 2026
…eyboard

The first console run went back to the controls pages: they read as a
message box without an arrow, so after two presses the intro took them
for the keyboard and pressed B, which in the intro goes back a page. Now
a message box gets A every 1.5 s whatever it shows, and the empty name
is entered only when the naming screen is detected. The naming screen
detector is the one from frlg/naming-screen (fork #81), unchanged; on the
lab's 331 captures it fires on the five keyboard shots and nothing else.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine dayfine added autostory AutoStory programs game:frlg FireRed/LeafGreen labels Nov 1, 2026
dayfine and others added 2 commits November 2, 2026 07:01
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
plan_naming_keys() plans the presses that type a name and stops before
START A; plan_naming_input() is now that plan plus START A.
type_name_without_confirming() types the name and leaves the naming screen
open, which is where SID Helper starts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine and others added 2 commits November 3, 2026 07:01
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine and others added 3 commits November 6, 2026 07:01
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Conflict in the registration lists (SerialPrograms/Source/VideoGames/PokemonFRLG/PokemonFRLG_Tests.cpp ): kept both sides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autostory AutoStory programs game:frlg FireRed/LeafGreen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant