Repository navigation
Conversation
Screenshot from the Paradise Protection Protocol battle start, showing the white dialog-continue arrow over the red crystal background.
…omation#42) * BDSP AutoStory: two new-game intro screens that are dialogs 019 and 020 are Rowan's lines with a name tab over the intro's sparkle background; the second's long line runs into the box's right end. Used by PokemonBDSP's intro screen tests (dayfine/Arduino-Source bdsp/actions-v4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E * BDSP AutoStory: X menu open and closed screens The X menu detector reads the menu's blue bottom bar, so it also sees a new game's menu, which has only BAG and OPTIONS. s38_xmenu is that menu (run 5's failure); the closed set is HOME, two overworld scenes and two intro screens from run 4 that must not read as a menu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E * BDSP: file the screens by detector, CLT style Move the frames from PokemonBDSP/AutoStory/ to the detectors they test, named <description>_True/False like every other game: DialogDetector for Rowan's two name-tab lines, MenuDetector for the new-game menu (BAG and OPTIONS only) and five screens that are not a menu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E * BDSP DialogDetector: a short-line dialogue box (Rowan's "Barry, is it?") An ordinary box whose right end is white where ShortDialogDetector's old check looks; the positive next to the two long-first-line screens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E * BDSP MenuDetector: the menu in Jubilife after the Town Map (NEW tag on TOWN MAP) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E * BDSP MenuDetector/DialogDetector: Floaroma menu with three NEW tags, dialogue boxes, cloud shadows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… (Persian) From PokemonAutomation/Arduino-Source#1851. Read by the MaxLairSummaryOpponentReader test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
force-pushed
the
swsh/maxlair-persian
branch
from
November 10, 2026 05:26
0183e14 to
fcd6615
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PokemonSwSh/MaxLair_SummaryOpponentReader/English_Persian.jpg, the Max Lair summary screen of a single-type Normal opponent (Persian), from PokemonAutomation/Arduino-Source#1851's testing.The
PokemonSwSh::MaxLairSummaryOpponentReadertest in dayfine/Arduino-Source#288 (to be upstream-ed) reads it and expectspersian