Skip to content

Fix Python 3.8 tests: drop str.removeprefix in mansion_switches - #101

Merged
dayfine merged 1 commit into
mainfrom
fix/py38-removeprefix
Nov 14, 2026
Merged

dayfine merged 1 commit into
mainfrom
fix/py38-removeprefix

Conversation

@dayfine

@dayfine dayfine commented Nov 14, 2026

Copy link
Copy Markdown
Owner

The unittest (3.8) job on main fails because mansion_switches in frlg_decomp_map_builder.py calls str.removeprefix, which only exists from Python 3.9. This replaces it with a startswith check and a slice, so the result is the same, including when the prefix is missing. The full unittest suite passes on Python 3.8 and 3.12, and frlg_decomp_map_builder --all --check reproduces all 156 base maps on both versions.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

@dayfine
dayfine merged commit b35582c into main Nov 14, 2026
7 of 8 checks passed
@dayfine
dayfine deleted the fix/py38-removeprefix branch November 14, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant