Skip to content

Tighten story wire reader validation - #105

Merged
dayfine merged 1 commit into
mainfrom
story-wire-nits
Nov 15, 2026
Merged

dayfine merged 1 commit into
mainfrom
story-wire-nits

Conversation

@dayfine

@dayfine dayfine commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Story wire readers could leak KeyError or TypeError, allowing malformed conformance inputs to pass as expected rejections.

Required-field parsing now raises field-specific ValueError, the conformance test accepts only that exception, and action specs reject arguments that are both required and given a fallback.

The checkpoint schema and contract documentation now label that schema as the legacy authored format and point v2 readers to checkpoint_wire.py and wire-conformance.json.

The targeted 5-test wire suite and the full isolated 644-test suite passed with 53 dependency/source-dependent skips, and the repository-wide contract-format check is clean.

@dayfine
dayfine marked this pull request as ready for review November 15, 2026 00:05
@dayfine
dayfine merged commit b677a0f into main Nov 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant