Skip to content

Implement pinned map exports and consumer integrity checks - #42

Merged
dayfine merged 2 commits into
design/map-consumer-processfrom
maps/consumer-integrity
Nov 5, 2026
Merged

dayfine merged 2 commits into
design/map-consumer-processfrom
maps/consumer-integrity

Conversation

@dayfine

@dayfine dayfine commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Stacked on #41 (design/map-consumer-process); the diff contains the implementation only.

Arduino map edits can drift from this repo after an import. Add consumer_sync check/update/compare to pin complete game exports to a PokemonSimulation commit and manifest SHA-256. The verifier reads immutable Git objects, requires main ancestry, checks every byte and inventory entry, and detects retired authoring modules and unlocked game directories. Updates validate first, refuse local drift, stage complete packs and replace the lock last, with rollback on ordinary swap failures.

A reusable Arduino CI action and workflow template are included. Simulation CI exercises the action on real published maps and proves a local edit is rejected. No Arduino files or #226 fixes are changed: consumer activation remains pending review of those differences, authoring-tool retirement in the owning PRs, and required-status configuration. Source-input provenance recovery and old reference-map consolidation remain tracked separately.

Validation:

  • Python 3.8: 42 map tests pass, including 16 consumer tests using actual temporary Git history.
  • Python 3.12: full suite passes, 337 tests, 14 skipped.
  • Real exported 22 BDSP + 53 FRLG maps pass the CLI check at publishing commit d7230a5899a33667cceba513f852f550794531c1.
  • Read-only comparison of #226 head e572a3036fb270f4cc0fbd6b66442872b0c0bd1a rejects the five changed maps and duplicate BDSP builder/parser; pending edits are preserved.

Review the Git source boundary, then sync/update behavior and regression cases. Integration commands and owner rollout steps are in integrations/arduino-source/README.md.

@dayfine
dayfine marked this pull request as ready for review November 5, 2026 06:43
@dayfine
dayfine merged commit d94f567 into design/map-consumer-process Nov 5, 2026
4 checks passed
@dayfine
dayfine deleted the maps/consumer-integrity branch November 5, 2026 06:43
dayfine added a commit that referenced this pull request Nov 5, 2026
* Design pinned map exports and consumer integrity checks

* Implement pinned map exports and consumer integrity checks (#42)

* Implement pinned map consumer updates and integrity checks

* Run consumer action from its pinned implementation directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant