Repository navigation
test: keep ordering holds until explicit release - #480
Conversation
PR SummaryLow Risk Overview In In Production code and public API are not modified. Reviewed by Cursor Bugbot for commit 1d9dc7c. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What does this change?
Refs #362. The foreign-PDO overlap test and ISO-TP queued-cancellation tests rely on their scripted server or actor staying blocked until the test releases it. Their holds now wait for an explicit signal, with finally-based release, instead of unblocking automatically after five or thirty seconds of host time. Positive waits retain their existing hang guards.
The PDO test keeps the second observation pending behind the first and preserves both live-mapping and payload assertions. The ISO-TP helper preserves the caller-token assertion and the disposal-start witness before releasing the actor, including the deliberately late-disposal case. The explicit Dispose runs as an observed operation in the normal test sequence. An outer finally releases and joins the actor even if setup or an earlier assertion fails; a using block owns channel cleanup.
All three existing cases pass. Three restored source mutations fail at runtime: replacing the shared PDO gate with independent gates, ignoring the caller's cancellation while waiting on the ISO-TP gate, and releasing the actor before the disposal witness. Only two test files change; production code and public API are unchanged. #362 remains open for the final inventory and remaining active confirmation-fixture audit.
Type of change
feat— new behaviour (minor release)fix/perf— bug or performance fix (patch release)docs/test/refactor/chore/ci— no releaseChecklist
Validation: 3,043 net10 tests, net48 compilation, nine verified packages, 50 engineering tests and requirements traceability. Production diff is empty; final CI coverage, Codecov partials/missing and all review comments will be checked before merge.