Skip to content

test: keep ordering holds until explicit release - #480

Merged
dborgards merged 2 commits into
mainfrom
fix/test-ordering-holds-362
Oct 27, 2026
Merged

dborgards merged 2 commits into
mainfrom
fix/test-ordering-holds-362

Conversation

@dborgards

@dborgards dborgards commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

What does this change?

Refs #362. The foreign-PDO overlap test and ISO-TP queued-cancellation tests rely on their scripted server or actor staying blocked until the test releases it. Their holds now wait for an explicit signal, with finally-based release, instead of unblocking automatically after five or thirty seconds of host time. Positive waits retain their existing hang guards.

The PDO test keeps the second observation pending behind the first and preserves both live-mapping and payload assertions. The ISO-TP helper preserves the caller-token assertion and the disposal-start witness before releasing the actor, including the deliberately late-disposal case. The explicit Dispose runs as an observed operation in the normal test sequence. An outer finally releases and joins the actor even if setup or an earlier assertion fails; a using block owns channel cleanup.

All three existing cases pass. Three restored source mutations fail at runtime: replacing the shared PDO gate with independent gates, ignoring the caller's cancellation while waiting on the ISO-TP gate, and releasing the actor before the disposal witness. Only two test files change; production code and public API are unchanged. #362 remains open for the final inventory and remaining active confirmation-fixture audit.

Type of change

  • feat — new behaviour (minor release)
  • fix / perf — bug or performance fix (patch release)
  • docs / test / refactor / chore / ci — no release
  • Breaking change

Checklist

  • CI=true build, net10 tests, format verification, fresh pack and package verification pass locally
  • Public API changes are documented with XML comments (no public API change)
  • New behaviour is covered by the existing ordering and contract tests
  • Related issue referenced: Tests: wall-clock-gated tests after #92 — the 2026-10-21 inventory #362, including comments 6322646996 and 6364500515

Validation: 3,043 net10 tests, net48 compilation, nine verified packages, 50 engineering tests and requirements traceability. Production diff is empty; final CI coverage, Codecov partials/missing and all review comments will be checked before merge.

@cursor

cursor Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to two integration tests; synchronization and cleanup only, with no runtime or API impact.

Overview
Test synchronization for ordering scenarios now blocks on explicit release instead of host-clock timeouts, so holds stay valid under slow CI or frozen manual time (refs #362).

In CanOpenForeignPdoObserveTests, the scripted upload hold switches from a SemaphoreSlim with a short timed wait to ManualResetEventSlim with Wait() until Set(), and a finally always signals release so a failed assertion cannot leave the server blocked.

In IsoTpChannelIntegrationTests (CallerCancelsASendQueuedOnTheGateAsync), the actor gate drops the 30-second wait in favor of indefinite wait until release, the channel is scoped in a using block, and an outer finally releases the actor and joins busy if setup or an earlier assertion fails before the disposal probe. Behavioral assertions (queued second observation, cancellation token, ObjectDisposedException after late dispose) are unchanged.

Production code and public API are not modified.

Reviewed by Cursor Bugbot for commit 1d9dc7c. Bugbot is set up for automated code reviews on this repo. Configure here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T04:09:50.667672Z 1d9dc7c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Owner Author

@codex review

Please review current head 1d9dc7c, including the linear disposal test sequence and its failure cleanup.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 1d9dc7c6bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dborgards
dborgards merged commit cc363d6 into main Oct 27, 2026
14 checks passed
@dborgards
dborgards deleted the fix/test-ordering-holds-362 branch October 27, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants