Skip to content

Open pull requests in browser tabs - #569

Merged
parsakhaz merged 2 commits into
mainfrom
fix-diff-viewer-switch
Aug 31, 2026
Merged

Open pull requests in browser tabs#569
parsakhaz merged 2 commits into
mainfrom
fix-diff-viewer-switch

Conversation

@parsakhaz

@parsakhaz parsakhaz commented Aug 31, 2026

Copy link
Copy Markdown
Member

Summary

  • make the inspector's Changes tab always render Pane's local review
  • replace the GitHub/Local mode switch with an Open PR action that creates or focuses a normal Browser tab at the pull request's /files URL
  • ignore legacy pane-review-default-mode=github preferences so pre-refresh users always return to local review
  • remove the embedded GitHub webview and obsolete review-mode preference/event machinery

Root cause

PR #512 moved the existing Review panel from the full editor stage into the constrained right inspector while retaining the embedded GitHub webview as an alternate persisted review mode. That made a full GitHub pull-request page occupy a surface designed for compact metadata and local changes, and users with the old github preference reopened directly into that poor-fit view.

The inspector now has one responsibility: local review. GitHub review opens in the existing full Browser panel system, where it has normal tab space, browser controls, and project-scoped persistent authentication.

References #512.

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm exec playwright test tests/review-availability.spec.ts (7 passed)
  • pnpm build:frontend

The E2E coverage seeds the legacy github preference, verifies local review still renders, opens PR #571 into a Browser tab, and checks the preloaded /files URL. The lint run retains five existing warnings in main/src/services/skillCacheManager.ts; there are no errors or new advisory findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T08:35:37.912881Z d55d11e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

React Doctor found 1 new issue in 1 file · 1 warning · score 85 / 100 (Great) · 6 fixed · vs main

1 warning

src/components/panels/diff/DiffPanel.tsx

  • ⚠️ L131 All state reset on prop change no-reset-all-state-on-prop-change

Reviewed by React Doctor for commit cd33fd1. See inline comments for fixes.

@parsakhaz parsakhaz changed the title Fix review mode switch in inspector Open pull requests in browser tabs Aug 31, 2026
@parsakhaz
parsakhaz force-pushed the fix-diff-viewer-switch branch from 48dcc74 to cd33fd1 Compare August 31, 2026 23:55
@parsakhaz
parsakhaz merged commit bb08ec0 into main Aug 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant