Open pull requests in browser tabs - #569
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found 1 new issue in 1 file · 1 warning · score 85 / 100 (Great) · 6 fixed · vs 1 warning
Reviewed by React Doctor for commit |
parsakhaz
force-pushed
the
fix-diff-viewer-switch
branch
from
August 31, 2026 23:55
48dcc74 to
cd33fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open PRaction that creates or focuses a normal Browser tab at the pull request's/filesURLpane-review-default-mode=githubpreferences so pre-refresh users always return to local reviewRoot cause
PR #512 moved the existing Review panel from the full editor stage into the constrained right inspector while retaining the embedded GitHub webview as an alternate persisted review mode. That made a full GitHub pull-request page occupy a surface designed for compact metadata and local changes, and users with the old
githubpreference reopened directly into that poor-fit view.The inspector now has one responsibility: local review. GitHub review opens in the existing full Browser panel system, where it has normal tab space, browser controls, and project-scoped persistent authentication.
References #512.
Testing
pnpm lintpnpm typecheckpnpm exec playwright test tests/review-availability.spec.ts(7 passed)pnpm build:frontendThe E2E coverage seeds the legacy
githubpreference, verifies local review still renders, opens PR #571 into a Browser tab, and checks the preloaded/filesURL. The lint run retains five existing warnings inmain/src/services/skillCacheManager.ts; there are no errors or new advisory findings.