Finding
tests/init-logic.test.ts:1807-1815 re-implements the ?? expression inside the test body and asserts the formatter, never touching src/cli/commands/init.ts — a vacuous test (PF-018).
Why deferred
Pre-existing; the file is not touched by PR #344. Flagged because it concerns the COMPLIANCE hud-only preservation path, and is exactly the bad precedent a contributor would copy when writing the tracker equivalent. PR #344's own testing-04 finding builds the executable-coverage pattern needed for the tracker case; applying that same fix to the compliance test is compliance-scoped work, out of scope here.
Suggested fix
Rewrite the test to exercise src/cli/commands/init.ts's actual hud-only preservation branch rather than re-implementing the ?? expression under test.
References
Finding
tests/init-logic.test.ts:1807-1815re-implements the??expression inside the test body and asserts the formatter, never touchingsrc/cli/commands/init.ts— a vacuous test (PF-018).Why deferred
Pre-existing; the file is not touched by PR #344. Flagged because it concerns the COMPLIANCE hud-only preservation path, and is exactly the bad precedent a contributor would copy when writing the tracker equivalent. PR #344's own
testing-04finding builds the executable-coverage pattern needed for the tracker case; applying that same fix to the compliance test is compliance-scoped work, out of scope here.Suggested fix
Rewrite the test to exercise
src/cli/commands/init.ts's actual hud-only preservation branch rather than re-implementing the??expression under test.References
.devflow/docs/reviews/feat-325-tracker-phase-3-init-selected-provider/2026-09-17_1253tests/init-logic.test.ts:1807-1815