fix(tests): make tarball verification portable on Windows (#752) - #755
Merged
Merged
Conversation
Run tar with an explicit argument array and a relative archive path so GNU tar does not treat Windows drive prefixes as remote hosts. Add real-archive integration coverage for absolute and relative paths, literal filenames, and missing archives. Fixes #752 Signed-off-by: CI Bot <ci@example.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
GNU tar on Windows Git Bash interprets the
C:prefix in an absolute archive path as a remote host, causing the packaged skill/manifest assertion to fail. Invoke tar throughexecFilefrom the archive's parent directory, passing./<basename>as an explicit argument. This also preserves spaces and literal filename characters without shell expansion.Add integration coverage using a real archive for absolute and relative paths, packaged entries and archive size, and missing-archive rejection. The integration project runs in the existing Ubuntu and Windows CI jobs.
Fixes #752
🔄 Type of Change
✅ Checklist
🧪 Testing
The normal pre-push hook passed all required steps:
pnpm run lintpnpm run typecheck:all— zero test type errorsnpm run clean && npm run buildnpm run test:unit— 5,376 passednpm run test:integration— 62 passed, 5 skippedAdditional validation passed:
Test configuration: Ubuntu 24.04.5 LTS, Node 22.22.3, Python 3.12.3, GNU tar 1.35.
📝 Additional Notes
Windows Git Bash validation has not been performed locally. The regression will run in Windows CI, using whichever tar is on that runner's PATH.