Build: drop glaze /GL+/LTCG so MSVC Release links#29
Open
Seltraeh wants to merge 1 commit into
Open
Conversation
glaze's vcpkg port pins /GL and /LTCG on its imported target; those propagate to every consumer, and MSVC's LTCG code-gen pass fails on the coroutine handler bodies with C4737 -> LNK1257, breaking Release/MinSizeRel links. Override glaze's interface flags to drop LTCG so Release builds link cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glaze's vcpkg port pins
/GL(whole-program optimization) and/LTCGon itsimported target for Release/MinSizeRel. Those flags propagate through
gimuserverto every consumer, and MSVC's LTCG code-gen pass fails on thecoroutine
HANDLEFbodies (e.g.UserInfo.cpp,GachaAction.cpp) withC4737 → LNK1257, so Release / MinSizeRel builds don't link.This overrides glaze's interface compile/link options to drop the LTCG flags.
The tradeoff is losing cross-TU inlining from glaze in exchange for Release
actually linking. Debug builds are unaffected.
Split out of a larger feature branch (per review feedback) as a standalone,
independent build fix.
🤖 Generated with Claude Code