Skip to content

fix(sessions): give Claude login a reusable starter profile - #683

Merged
defangdevs merged 1 commit into
masterfrom
codex/claude-login-profile
Sep 11, 2026
Merged

fix(sessions): give Claude login a reusable starter profile#683
defangdevs merged 1 commit into
masterfrom
codex/claude-login-profile

Conversation

@defangdevs

@defangdevs defangdevs commented Sep 11, 2026

Copy link
Copy Markdown
Owner

After Claude sign-in, the auto-started remote-control session had no profile. The default profile seed runs at supervisor startup, so signing in did not ensure that Add session offered the same worker.

Successful Claude login now ensures a claude profile exists and resolves the auto-started session through it. New profiles contain only HARNESS=claude, leaving model and effort at their defaults. Existing settings are preserved; a name already used for another harness gets a numbered alternative. Repeat sign-ins ensure the profile remains available without adding duplicate sessions or changing existing workers. Profile-storage failures retain the previous bare-worker fallback.

This change covers Claude only. Related Codex work remains in #625 / #623. No changes to authentication, permissions, or deployment configuration.

Validation:

  • Full native set: nix build -L --keep-going .#ci-native on aarch64-linux.
  • Profile tests: 62 passed, including HTTP creation of a second remote-control session from the login profile.
  • Native renderer: 150 tests, one existing skip.
  • Regenerated module and golden fixtures; diff reviewed.
  • Assembled daemon smoke-tested with the installed profile CLI in an isolated HOME.
  • Connect VM script evaluated and checked with pinned ty and ruff; VM execution runs in x86 CI.
  • Code and security review: profile writes use the env-store lock, existing settings are preserved, and launch arguments use the shared resolver.
  • GitHub CI: native checks, all four VM lanes, and the final validation gate passed.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4749ec3e-71f7-4d3e-829a-9d4900c3fc3b

📥 Commits

Reviewing files that changed from the base of the PR and between 045dc6f and f710533.

📒 Files selected for processing (5)
  • modules/agent-box.nix
  • modules/src/settings-daemon.py
  • tests/connect.nix
  • tests/golden/web/payloads/agent-box-settings/bin/agent-box-settings
  • tests/test-profile-panel.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@defangdevs
defangdevs merged commit 9e113ce into master Sep 11, 2026
7 checks passed
@defangdevs
defangdevs deleted the codex/claude-login-profile branch September 11, 2026 22:59
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Agent-Box Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant