Repository navigation
Ship third-party licence notices, pin actions to commits, name one copyright holder - #5
Merged
Merged
Conversation
…pyright holder The same three defects reported against verified-python (dekrops/verified-python#9, #10, #14) are present here. - THIRD-PARTY-LICENSES.md is generated from rust/Cargo.lock by cargo-about, for the WebAssembly target, and ships in the npm package. CI fails when it differs from the lockfile and when the packed tarball lacks it. - Every GitHub Action is pinned to a commit. The Rust toolchain comes from rust/rust-toolchain.toml through rustup, not from an action tracking a branch. - NOTICE and package.json say Krops GmbH, as verified-cli and wvp do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cargo-about reads metadata for all targets; the clippy step before it had only fetched what the WebAssembly target needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue was filed here, but the three defects reported against the Python SDK (dekrops/verified-python#9, #10, #14) exist in this repository too. This is the same fix; the Python one is dekrops/verified-python#15.
Third-party licence notices
The WebAssembly module links crates under BSD-3-Clause, MIT, Apache-2.0 and Unicode-3.0, and the npm package is a binary distribution of them. 0.1.0 on npm shipped without their notices.
THIRD-PARTY-LICENSES.mdis generated fromrust/Cargo.lockbycargo-about, limited to thewasm32-unknown-unknowntarget, with the template Generate the third-party notices a binary must carry, and keep them current verified-cli#33 uses.filesinpackage.json. I packed the tarball locally and checked it is inside.NOTICEno longer points atrust/, which is not in the package, and now nameswasm-bindgen, whose generated loader ships indist/native/.Actions pinned to commits
Every action is pinned to the commit of its latest release, with the version as a comment.
dtolnay/rust-toolchain@masteris replaced byrustupreadingrust/rust-toolchain.toml.One copyright holder
NOTICEandpackage.jsonnow say Krops GmbH, matchingverified-cliandwvp. Please confirm this is the right entity; "Verified AI" was my wording in the scaffold.Not in this PR: the release
0.1.0 on npm can't be changed, so the notices only reach users with a new version. This PR does not bump the version or publish.
Checked
🤖 Generated with Claude Code